paperclip/scripts
Dotta b1efd65edc
fix: continue interrupted task conversations with bounded retries (#13237)
## Thinking Path

> - Paperclip manages AI agents and their tasks.
> - A task can outlive a provider process or a server restart.
> - Legacy recovery treated unknown tool outcomes as a permanent
execution hold.
> - That hold could also reject a later user message.
> - A conversation turn can use prior history without replaying prior
tool calls.
> - This pull request lets supported conversation adapters continue
within the existing retry budget.
> - Users can send a new message after automatic attempts stop.

## Linked Issues or Issue Description

**What happened?**

A server restart could interrupt a local ACP run and leave its task
behind a permanent recovery hold. A later user message could be
cancelled before the provider answered. The immediate recovery path
could also create a successor outside the durable failure counter.

**Expected behavior**

Continue with a bounded new conversation turn. Preserve a compatible
provider session or use full task context when it is unavailable. Do not
replay recorded tools. When automatic attempts stop, allow a new user
request through the normal execution gates.

**Steps to reproduce**

1. Start a task with a local conversation adapter.
2. Restart the server while the provider is working.
3. Let the previous run become interrupted.
4. Send a follow-up message and observe the recovery hold on the old
behavior.

Related work: Refs #13075 for durable task recovery. Refs #12946 for
retry-limit and checkout-lock handling. This change routes conversation
recovery through the existing bounded scheduler.

## What Changed

- Mark supported local conversation failures for continuation. Keep
native-runner and non-conversation recovery rules.
- Carry an interruption notice into the next turn. Retain stopped ACP
session history even when a write outcome is unknown.
- Clear unavailable ACP sessions so the next bounded attempt can use
full task context.
- Route immediate failure recovery through the same durable scheduler as
process-loss recovery. Release only the predecessor checkout when its
retry takes ownership.
- Retire obsolete conversation holds using immutable run evidence, in
bounded batches with an activity record. Preserve outcome evidence and
do not wake historical tasks.
- Block actual admission and Resume while a predecessor process or
environment lease is still active. Keep the original interruption notice
after a rejected wake. Preserve the upstream blocked-wake waiting
contract: bounded retry planning can happen during cleanup, while
deferred messages and execution remain gated.
- Add subprocess and database regression tests. Update the execution
contract.
- Add the current thread-status field to the native recovery provider
fixture so its damaged-journal test reaches the intended boundary.
Tolerate an already-exited fixture process during test cleanup while
still asserting both processes terminate.

## Verification

- Workspace typecheck passed: `pnpm -r typecheck`.
- Build passed: `pnpm build`.
- Module boundaries passed: `pnpm check:module-boundaries`.
- Focused tests passed: 293 recovery/session/dispatch tests, 66 retry
and response-gate tests, and 37 native-session tests. Some suites
overlap.
- Tests cover interrupted writes, missing sessions, concurrent retries,
restart persistence, pending questions and approvals, execution gates,
and historical holds.
- Built the Rust test executables with `pnpm --filter
@paperclipai/paperclip-runner build:rust` for native-runner
verification.
- Full Vitest coverage verified locally using the repository’s general
and serialized shards, with focused reruns for failures and files not
reached after a shard stopped. The ownership-gate regression is fixed
and the complete affected server shard passes (1,390 tests). Local
parallel runs also hit temporary-directory, resource, and timing
failures; those suites pass with canonical temporary paths and
sequential reruns. No test timeouts were increased.
- Final merged-branch regression run: 577 tests pass across process
recovery, retry scheduling, liveness, durable chat, wake-queue
application/adapter, dispatch, continuation, native sessions, and task
chat. Earlier focused verification also passed 19 native control tests.
Token gates and whitespace validation pass.
- Browser verification passed all three ACP Stop/continue/pause
scenarios, including a rerun after merging the upstream waiting
behavior: `PAPERCLIP_E2E_PORT=3397 pnpm test:e2e
tests/e2e/acp-stop-continuation.spec.ts`. The interrupted-write case
verifies that follow-up completes without a repeated write.

- Final-head [CI run
34625037394](https://github.com/paperclipai/paperclip/actions/runs/34625037394)
passed on `06ac4bd9d150f8b209a96e5fd609c696958794a0`: all 31 reported
checks are green, including server/workspace suites, all browser shards,
native runner verification, build, typecheck, release dry run, and
aggregate gates. The two conditional Storybook checks were skipped.
Greptile reviewed this exact commit at 5/5; all review threads are
resolved.

## Risks

- A new model turn can choose to repeat an action. Paperclip does not
replay recorded tool calls and does not certify unknown action outcomes.
- Conversation adapters now stop after their retry budget instead of
requiring action reconciliation. Explicit Stop, pause, dependency,
approval, budget, and ownership gates remain in force.
- No schema migration or dependency changes. Historical holds are folded
without changing task status or waking work.

## Model Used

OpenAI GPT-6 through Codex, with reasoning, repository tools, code
execution, and test execution. The session does not expose a more
specific model build ID or context-window size.

## Checklist

- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have checked ROADMAP.md and confirmed this PR does not duplicate
planned core work
- [x] I have searched GitHub for duplicate or related PRs and linked
them above
- [x] I have either (a) linked existing issues with `Fixes: #` / `Closes
#` / `Refs #` OR (b) described the issue in-PR following the relevant
issue template
- [x] I have not referenced internal/instance-local Paperclip issues or
links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip`
URLs)
- [x] My branch name describes the change (e.g. `docs/...`, `fix/...`)
and contains no internal Paperclip ticket id or instance-derived details
- [x] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [x] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [x] All Paperclip CI gates are green
- [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups
- [x] I will address all Greptile and reviewer comments before
requesting merge

---------

Co-authored-by: Paperclip <noreply@paperclip.ing>
2026-09-11 12:16:04 -05:00
..
__tests__ fix(ci): reuse cloud source verification for npm canaries (#13233) 2026-09-11 09:26:26 -07:00
install-sh-fixtures
lib feat: add experimental native chat connectors (#13038) 2026-09-10 10:06:45 -05:00
mcp-fixtures fix: continue interrupted task conversations with bounded retries (#13237) 2026-09-11 12:16:04 -05:00
smoke feat: add experimental native chat connectors (#13038) 2026-09-10 10:06:45 -05:00
tests feat: add experimental native chat connectors (#13038) 2026-09-10 10:06:45 -05:00
acpx-patch-packaging.test.mjs fix(paperclip-runner): bump claude-agent-acp pin to 0.73.0 (#13162) 2026-09-10 11:35:33 -07:00
assert-cloud-image-sentry.mjs Install the declared Sentry server package into the hosted image (#12330) 2026-08-27 19:10:49 -07:00
assert-orphan-reaping.sh fix(docker): make tini PID 1 in the server image so adopted orphans are reaped (#12137) 2026-08-25 09:52:39 -07:00
backfill-issue-reference-mentions.ts
backup-db.sh
benchmark-skill-preparation.ts fix(skills): reuse validated runtime revisions during preparation (#13042) 2026-09-08 09:35:32 -05:00
bootstrap-npm-package.mjs
bootstrap-npm-package.test.mjs
build-npm.sh
build-standalone-public-packages.mjs
capture-pap-2351-binding-picker.mjs
chat-adapter-patch-packaging.test.mjs feat: add opt-in chat provider and data foundation (#13100) 2026-09-09 13:49:12 -05:00
check-docker-deps-stage.mjs
check-forbidden-tokens.mjs
check-module-boundaries.mjs refactor(server): move the admission half of the deferred wake state machine into the wake-queue module (#13136) 2026-09-10 00:55:48 -07:00
check-module-boundaries.test.mjs refactor(server): move the admission half of the deferred wake state machine into the wake-queue module (#13136) 2026-09-10 00:55:48 -07:00
check-no-git-push.mjs
check-no-git-push.test.mjs
check-node-version-policy.mjs
check-release-package-bootstrap.mjs
check-release-package-bootstrap.test.mjs
check-task-chat-motion.mjs
check-token-gates.mjs
clean-install-git.sh
clean-install-npm.sh
clean-onboard-git.sh
clean-onboard-npm.sh
clean-onboard-ref.sh
cli-bundled-npm-dependencies.mjs
cloud-readiness.mjs fix(ci): verify deployable cloud artifacts independently (#13192) 2026-09-10 21:08:29 -07:00
cloud-source-verification.mjs fix(ci): reuse cloud source verification for npm canaries (#13233) 2026-09-11 09:26:26 -07:00
cloud-source-verification.test.mjs fix(ci): reuse cloud source verification for npm canaries (#13233) 2026-09-11 09:26:26 -07:00
codemod-extract-colors.mjs
codemod-extract-misc.mjs
codemod-extract-sizes.mjs
codemod-extract-type.mjs
codemod-type-ladder.mjs
codex-acp-network-policy.test.mjs fix(adapters): prevent engine fallback and preserve usable runtime defaults (#13105) 2026-09-09 13:27:24 -05:00
create-github-release.sh
dev-both.mjs
dev-runner-native-binary.mjs feat(runner): integrate Codex native execution (#12616) 2026-08-31 22:51:17 -05:00
dev-runner-options.ts fix(dev): honor --data-dir isolation (#12193) 2026-08-26 09:08:31 -05:00
dev-runner-output.mjs
dev-runner-output.ts
dev-runner-paths.mjs
dev-runner-snapshot.mjs
dev-runner.mjs
dev-runner.ts fix(runner): recover native sessions across restarts (#12845) 2026-09-04 15:03:53 -05:00
dev-service-profile.ts
dev-service.ts fix(dev): honor --data-dir isolation (#12193) 2026-08-26 09:08:31 -05:00
discord-daily-digest.sh
docker-build-test.sh fix(docker): make tini PID 1 in the server image so adopted orphans are reaped (#12137) 2026-08-25 09:52:39 -07:00
docker-entrypoint.sh
docker-onboard-smoke.sh Follow the current onboarding arc in the release smoke (#12423) 2026-08-28 07:21:08 -07:00
docker-onboard-smoke.test.mjs Follow the current onboarding arc in the release smoke (#12423) 2026-08-28 07:21:08 -07:00
draft-stable-notes.sh feat(release): thorough notes skeletons — nest each PR's summary at creation (#12124) 2026-08-24 20:51:33 -07:00
draft-stable-notes.test.mjs feat(release): thorough notes skeletons — nest each PR's summary at creation (#12124) 2026-08-24 20:51:33 -07:00
e2e-install-lifecycle.sh
e2e-mcp-user-stories.mjs
e2e-shard-durations.json test(e2e): shorten and split Smoke Lab coverage (#12506) 2026-08-31 10:15:39 -05:00
e2e-shard.mjs feat(connections): connect services from native task feeds (#13058) 2026-09-08 15:55:26 -05:00
e2e-update-migrations.sh
ensure-plugin-build-deps.mjs
ensure-workspace-package-links.ts
extract-proposed-events.mjs
extract-proposed-events.test.mjs
general-server-shard-durations.json fix(ci): split release chat verification into test shards (#13198) 2026-09-10 20:30:30 -07:00
general-server-shard.mjs
generate-company-assets.ts
generate-feature-catalog.ts
generate-npm-package-json.mjs
generate-org-chart-images.ts
generate-org-chart-satori-comparison.ts
generate-plugin-package-json.mjs
generate-runner-api-reference.mjs feat(runner): add guarded API search and call fallback (#13003) 2026-09-07 14:14:43 -05:00
generate-runner-experimental-api-metadata.mjs feat(runner): add guarded API search and call fallback (#13003) 2026-09-07 14:14:43 -05:00
generate-ui-package-json.mjs
ingest-app-definitions.mjs feat: add experimental native chat connectors (#13038) 2026-09-10 10:06:45 -05:00
install.sh
kill-agent-browsers.sh
kill-dev.sh
kill-vitest.sh
kill-workspaces.sh
link-plugin-dev-sdk.mjs
link-plugin-dev-sdk.test.js
measure-issue-chat-long-thread.mjs
migrate-inline-env-secrets.ts
paperclip-commit-metrics.ts
paperclip-issue-update.sh
prepare-bundled-package.mjs Build isolated preview artifacts for exact-source deployments (#13041) 2026-09-08 09:21:58 -05:00
prepare-server-ui-dist.sh
preview-artifacts.mjs fix(release): publish exact-source cloud migrators on merge (#13188) 2026-09-10 21:07:38 -07:00
preview-artifacts.test.mjs fix(ci): bake the managed runtime identity into cloud images (#13210) 2026-09-11 00:58:27 -07:00
provision-worktree-runtime.sh fix(scripts): silence pnpm DEP0169 at provisioning install call sites (#12228) 2026-08-26 10:42:13 -07:00
provision-worktree.sh fix(workspaces): preserve dependency provisioning failures (#13093) 2026-09-09 10:14:58 -05:00
release-lib.sh fix(release): skip lifecycle scripts for bundle staging (#12585) 2026-08-31 09:14:08 -05:00
release-lib.test.mjs fix(release): skip lifecycle scripts for bundle staging (#12585) 2026-08-31 09:14:08 -05:00
release-package-manifest.json
release-package-map.mjs
release-package-map.test.mjs
release-registry-versions.mjs
release-registry-versions.test.mjs
release.sh
repair-pr-prep-workspace-attachment.mjs
request-hot-restart.ts
rollback-latest.sh
run-typecheck-build-gaps.mjs
run-vitest-stable.mjs fix(ci): split release chat verification into test shards (#13198) 2026-09-10 20:30:30 -07:00
runner-api-eval-worker.ts feat(connections): connect services from native task feeds (#13058) 2026-09-08 15:55:26 -05:00
screenshot-blocked-inbox.mjs
screenshot-file-viewer.mjs
screenshot-fork-flow.mjs
screenshot-notion-connect-flow.mjs
screenshot-one.mjs
screenshot-pap2373.mjs
screenshot-recovery-card.cjs
screenshot-subissues.mjs
screenshot-verdicts.mjs
screenshot.cjs
serialized-shard-durations.json
serve-storybook-static.mjs
service-onboard-smoke.sh test(release-smoke): cover the background-service leg of onboarding (#12151) 2026-08-25 01:05:27 -07:00
service-onboard-smoke.test.mjs test(release-smoke): cover the background-service leg of onboarding (#12151) 2026-08-25 01:05:27 -07:00
storybook-visual-baseline.mjs
test-install-sh-docker.sh
test-line-shard.mjs fix(ci): split release chat verification into test shards (#13198) 2026-09-10 20:30:30 -07:00
verify-release-registry-state.mjs
verify-release-registry-state.test.mjs