History

Nicky Leach 198fc8b281 fix(adapter-utils): harden the referenced-project ignore scan (#12214 ) ## Thinking Path > - Paperclip is the open source app people use to manage AI agents for work > - Agent adapters stage referenced projects into controlled sandboxes > - The ignore scan must preserve exact Git path bytes and fail closed on unsafe input > - Unbounded ignored-path data and raw diagnostics can harm resource use or expose host details > - This pull request adds exact path parsing, input bounds, fixed failure categories, and saturation-only retry > - The benefit is safer and more predictable referenced-project staging ## Linked Issues or Issue Description What happened? The referenced-project ignore scan trimmed NUL-delimited Git paths. It also accepted a large ignored-path set and exposed raw failure details through staging errors and warnings. Expected behavior The scan must preserve leading and trailing whitespace in Git paths. It must reject oversized ignored-path data and expose only fixed failure categories. Steps to reproduce 1. Run the referenced-project ignore scan with paths that start or end with whitespace. 2. Provide more than 10,000 ignored entries or more than 2 MiB of path bytes. 3. Trigger a scan failure and inspect the reported reason. Paperclip version or commit `d560bc2ae2` Deployment mode Built from source. Installation method Built from source. Agent adapter(s) involved Not adapter-specific. Database mode Not database-related. Additional context This change covers the overlay diff, untracked, deleted, and ignored Git paths. It also retries only typed scheduler saturation failures. ## What Changed - Preserve all bytes in NUL-delimited Git path records. - Bound ignored-entry count and total UTF-8 path bytes during parsing. - Redact scan failure details to three fixed reason categories. - Retry only the typed scheduler saturation error, with three total attempts and 1 second then 2 second waits. - Add tests for path whitespace, limits, diagnostics, retry behavior, and scheduler code parity. ## Verification - `npx tsc --noEmit` in `packages/adapter-utils` passed. - `npx vitest run packages/adapter-utils` passed with 977 tests and 4 skipped. - Continuous integration must run the server suite and the full repository gates. ## Risks The scan now rejects ignored-path data above fixed limits. Saturation retries add up to 3 seconds before a final failure. The resolver still fails closed for all other errors. ## Model Used OpenAI GPT-5. The model used tool calls, code inspection, and command execution. The exact context window and reasoning mode are not exposed by the runtime. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have searched GitHub for duplicate or related PRs and linked them above - [x] I have either (a) linked existing issues with `Fixes: #` / `Closes #` / `Refs #` OR (b) described the issue in-PR following the relevant issue template - [x] I have not referenced internal/instance-local Paperclip issues or links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip` URLs) - [x] My branch name describes the change (e.g. `docs/...`, `fix/...`) and contains no internal Paperclip ticket id or instance-derived details - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] All Paperclip CI gates are green - [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>		2026-08-26 08:30:42 -07:00
..
src	fix(adapter-utils): harden the referenced-project ignore scan (#12214 )	2026-08-26 08:30:42 -07:00
CHANGELOG.md	fix: bound workspace Git scans (#11572 )	2026-08-17 22:11:30 -05:00
README.md	PAPA-430: workspace finalize gates + no-remote-git enforcement (#6969 )	2026-05-29 08:25:29 -07:00
package.json	build(deps-dev): bump typescript from 5.9.3 to 7.0.2 (#11880 )	2026-08-25 14:49:05 -07:00
tsconfig.json	Fix root TypeScript solution config	2026-03-09 14:09:30 -05:00

README.md

@paperclipai/adapter-utils

Shared utilities for Paperclip adapters: process spawning, environment injection, sandbox/SSH transport, workspace sync, and the round-trip helpers that move code between the local execution-workspace cwd and wherever the agent actually runs.

For the adapter-author guide see docs/adapters/creating-an-adapter.md and the in-repo notes at packages/adapters/AUTHORING.md.

No-remote-git contract

The local execution-workspace cwd is the only persistence boundary across runs. No adapter may depend on a git remote for cross-run state.

Adapters that run the agent on a different host should use the SSH round-trip helpers in src/ssh.ts:

prepareWorkspaceForSshExecution({ spec, localDir, remoteDir }) — bundles the local cwd (tracked files, dirty edits, untracked additions, and the git history needed to reconstruct it) to remoteDir before the run starts. Runs with no git remote configured.
restoreWorkspaceFromSshExecution({ spec, localDir, remoteDir, ... }) — syncs the remote cwd back into localDir after the run, including any new commits the agent created. Also runs with no git remote configured.

prepareRemoteManagedRuntime in src/remote-managed-runtime.ts wraps both calls for adapters that want a per-run remote workspace and an automatic restoreWorkspace() finally hook.

The invariant is pinned by the no-remote-git contract case in src/ssh-fixture.test.ts, which asserts that a remote-only commit propagates to the local worktree through the prepare → restore round-trip with no git remote configured at any point. Do not regress that test.