From 18c7f344d5b813b83db1ef4b6039146a2464f298 Mon Sep 17 00:00:00 2001
From: Dewalt <>
Date: Thu, 10 Oct 2024 05:23:37 -0500
Subject: [PATCH] Rev 1.8.1b

---
 README.md     | 3 +++
 pimpmykali.sh | 6 +++---
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/README.md b/README.md
index b05fd33..7a3f8b4 100644
--- a/README.md
+++ b/README.md
@@ -46,6 +46,9 @@ sudo ./pimpmykali.sh
 # Writeups / Honorable Mentions
   - ip3c4c_n00b https://ip3c4c.com/2202_homelab_vmware/
 
+# Revision 1.8.1b - Updated Ghidra Download function
+  - corrected download
+
 # Revision 1.8.1a - Added Andrew B's IoT and Hardware Hacking Course Setup 
   - Menu option Y or y
     - stand alone function
diff --git a/pimpmykali.sh b/pimpmykali.sh
index 9ab54ff..20fa560 100755
--- a/pimpmykali.sh
+++ b/pimpmykali.sh
@@ -2339,10 +2339,10 @@ peh_weblab_setup() {
 
 fix_ghidra() {
     eval apt -y install jq curl
-    LATEST_URL="https://api.github.com/repos/NationalSecurityAgency/ghidra/releases/latest"
-    JSON_DATA=$(curl -s "${LATEST_URL}")
-    DOWNLOAD_URL=$(echo "$JSON_DATA" | jq -r '.assets[] | select(.name | test("ghidra_[0-9]+\\.[0-9]+\\.[0-9]+_PUBLIC_[0-9]{8}\\.zip")) | .browser_download_url')
 
+    LATEST_URL="https://api.github.com/repos/NationalSecurityAgency/ghidra/releases/latest"
+    JSON_DATA=$(curl -s "${LATEST_URL}" | tr -d '\000-\037')
+    DOWNLOAD_URL=$(echo "$JSON_DATA" | jq -r '.assets[] | select(.name | contains("_PUBLIC_")).browser_download_url')
     GHIDRA_INSTALL_DIR="/opt/ghidra"
     GHIDRA_TMP_ZIP="/tmp/ghidra.zip"
     GHIDRA_TMP_DIR=$(mktemp -d)