From 7e768f3d096d6fc14d8dac582f8a970c94f41db0 Mon Sep 17 00:00:00 2001
From: Jake Turner <jturner@cosmistack.com>
Date: Sun, 17 May 2026 06:30:22 +0000
Subject: [PATCH] fix(KB): guardrail bypass during estimate load + Transition
 sibling (PR #901 review)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

- Disable TierSelectionModal Submit while the embed-estimate query is in
flight, so a fast click can't slip past the guardrail with an undefined
estimate.
- Move KbGuardrailModal out of the outer <Transition> and render it as a
Fragment sibling — Headless UI's Transition expects Transition.Child
descendants, not raw conditional siblings.
---
 .../inertia/components/TierSelectionModal.tsx | 28 ++++++++++---------
 1 file changed, 15 insertions(+), 13 deletions(-)

diff --git a/admin/inertia/components/TierSelectionModal.tsx b/admin/inertia/components/TierSelectionModal.tsx
index f135f3c..3db5094 100644
--- a/admin/inertia/components/TierSelectionModal.tsx
+++ b/admin/inertia/components/TierSelectionModal.tsx
@@ -74,7 +74,7 @@ const TierSelectionModal: React.FC<TierSelectionModalProps> = ({
     [selectedTierResources]
   )
 
-  const { data: embedEstimate } = useQuery({
+  const { data: embedEstimate, isLoading: isEstimating } = useQuery({
     queryKey: ['embedEstimateBatch', embedEstimateRequest],
     queryFn: () => api.estimateEmbeddingBatch(embedEstimateRequest),
     enabled: embedEstimateRequest.length > 0,
@@ -158,6 +158,7 @@ const TierSelectionModal: React.FC<TierSelectionModalProps> = ({
   }
 
   return (
+    <>
     <Transition appear show={isOpen} as={Fragment}>
       <Dialog as="div" className="relative z-50" onClose={onClose}>
         <Transition.Child
@@ -345,7 +346,7 @@ const TierSelectionModal: React.FC<TierSelectionModalProps> = ({
                     variant='primary'
                     size='lg'
                     onClick={handleSubmit}
-                    disabled={!localSelectedSlug}
+                    disabled={!localSelectedSlug || (embedEstimateRequest.length > 0 && isEstimating)}
                   >
                     Submit
                   </StyledButton>
@@ -355,18 +356,19 @@ const TierSelectionModal: React.FC<TierSelectionModalProps> = ({
           </div>
         </div>
       </Dialog>
-      {guardrailVerdict && (
-        <KbGuardrailModal
-          isOpen={true}
-          verdict={guardrailVerdict}
-          onConfirm={() => {
-            setGuardrailVerdict(null)
-            finalizeSubmit()
-          }}
-          onCancel={() => setGuardrailVerdict(null)}
-        />
-      )}
     </Transition>
+    {guardrailVerdict && (
+      <KbGuardrailModal
+        isOpen={true}
+        verdict={guardrailVerdict}
+        onConfirm={() => {
+          setGuardrailVerdict(null)
+          finalizeSubmit()
+        }}
+        onCancel={() => setGuardrailVerdict(null)}
+      />
+    )}
+    </>
   )
 }