From e5565d1e9553dd88b96425c5b02e8be2037a9e39 Mon Sep 17 00:00:00 2001 From: jakeaturner Date: Tue, 9 Jun 2026 02:29:53 +0000 Subject: [PATCH] refactor(supply-depot): extract version and subtitle helpers instead of IIFE for readability --- admin/inertia/pages/supply-depot.tsx | 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/admin/inertia/pages/supply-depot.tsx b/admin/inertia/pages/supply-depot.tsx index 0729356..44c97f3 100644 --- a/admin/inertia/pages/supply-depot.tsx +++ b/admin/inertia/pages/supply-depot.tsx @@ -785,6 +785,19 @@ function AppCard({ // without a doc section (custom apps, undocumented catalog apps) so the Docs item is hidden. const docLink = getSupplyDepotDocLink(service.service_name) + // Subtitle under the app name: the powered-by name plus the installed image tag + // (e.g. "Kiwix · 3.7.0"). Only installed apps have a meaningful running version; a + // not-yet-installed catalog entry shows just the powered-by name. Null when neither exists. + const version = service.installed ? extractTag(service.container_image) : '' + const subtitle = + !service.powered_by && !version ? null : ( +

+ {service.powered_by} + {service.powered_by && version ? ' · ' : ''} + {version ? {version} : null} +

+ ) + function toggleDropdown(e: React.MouseEvent) { e.stopPropagation() onOpenDropdown(isDropdownOpen ? null : service.service_name) @@ -818,20 +831,7 @@ function AppCard({

{service.friendly_name ?? service.service_name}

- {(() => { - // Show the installed image tag next to the powered-by name (e.g. "Kiwix · 3.7.0"). - // Only for installed apps — a not-yet-installed catalog entry has no meaningful - // running version. Falls back to just the version if powered_by is unset. - const version = service.installed ? extractTag(service.container_image) : '' - if (!service.powered_by && !version) return null - return ( -

- {service.powered_by} - {service.powered_by && version ? ' · ' : ''} - {version ? {version} : null} -

- ) - })()} + {subtitle}