fix(quickemu): disable serial by default for macOS and Windows
- Remove noisy "Serial: (off)" echo and add explanatory comment
- Stop forcing serial="${serial:-socket}" early; leave unset and set
per-guest after config
- Set serial="none" for macOS and Windows guests, otherwise default to
"socket"
- Reduce terminal clutter for guests that do not emit useful serial
output
- Document how to override: use --serial or set serial=socket in the VM
.conf
Signed-off-by: Martin Wimpress <martin@wimpress.org>
This commit is contained in:
parent
eb98ce1160
commit
7cbc062a57
20
quickemu
20
quickemu
|
|
@ -2111,7 +2111,8 @@ function vm_boot() {
|
|||
|
||||
if [ "${serial}" == "none" ]; then
|
||||
args+=(-serial none)
|
||||
echo " - Serial: (off)"
|
||||
# No log output when serial is disabled - it's the default for macOS/Windows
|
||||
# and provides no useful information to the user
|
||||
elif [ "${serial}" == "telnet" ]; then
|
||||
# Find a free port to expose serial-telnet to the guest
|
||||
TEMP_PORT="$(get_port "${serial_telnet_port}" 9)"
|
||||
|
|
@ -2548,7 +2549,8 @@ spice_port="${spice_port:-}"
|
|||
monitor="${monitor:-socket}"
|
||||
monitor_telnet_port="${monitor_telnet_port:-4440}"
|
||||
monitor_telnet_host="${monitor_telnet_host:-localhost}"
|
||||
serial="${serial:-socket}"
|
||||
# Serial default is set later based on guest_os (after config is sourced)
|
||||
serial="${serial:-}"
|
||||
serial_telnet_port="${serial_telnet_port:-6660}"
|
||||
serial_telnet_host="${serial_telnet_host:-localhost}"
|
||||
# options: ehci (USB2.0), xhci (USB3.0)
|
||||
|
|
@ -2809,6 +2811,20 @@ if [ -n "${VM}" ] && [ -e "${VM}" ]; then
|
|||
SOCKET_MONITOR="${VMDIR}/${VMNAME}-monitor.socket"
|
||||
SOCKET_SERIAL="${VMDIR}/${VMNAME}-serial.socket"
|
||||
|
||||
# Set serial default based on guest_os if not explicitly configured.
|
||||
# macOS and Windows guests don't output anything useful to serial by default,
|
||||
# so disable it to reduce clutter. Users can still override with --serial.
|
||||
if [ -z "${serial}" ]; then
|
||||
case "${guest_os}" in
|
||||
macos|windows|windows-server)
|
||||
serial="none"
|
||||
;;
|
||||
*)
|
||||
serial="socket"
|
||||
;;
|
||||
esac
|
||||
fi
|
||||
|
||||
# if disk_img is not configured, do the right thing.
|
||||
if [ -z "${disk_img}" ]; then
|
||||
disk_img="${VMDIR}/disk.${disk_format}"
|
||||
|
|
|
|||
Loading…
Reference in New Issue