From 0a4223ffeb6491a0b9bc70a3072e8ffefcae62db Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Adri=C3=A1n=20Chaves?= Date: Sat, 15 Mar 2025 02:45:31 +0100 Subject: [PATCH] Update test expectations --- tests/test_spider.py | 19 +------------------ tests/test_spider_yield_seeds.py | 14 ++++++++++++++ 2 files changed, 15 insertions(+), 18 deletions(-) diff --git a/tests/test_spider.py b/tests/test_spider.py index b7ddb37c4..f0a8ad4d7 100644 --- a/tests/test_spider.py +++ b/tests/test_spider.py @@ -1,7 +1,7 @@ import gzip import warnings from io import BytesIO -from logging import ERROR, WARNING +from logging import WARNING from pathlib import Path from typing import Any from unittest import mock @@ -447,23 +447,6 @@ class TestCrawlSpider(TestSpider): assert hasattr(spider, "_follow_links") assert not spider._follow_links - @inlineCallbacks - def test_start_url(self): - class TestSpider(self.spider_class): - name = "test" - start_url = "https://www.example.com" - - crawler = get_crawler(TestSpider) - with LogCapture("scrapy.core.engine", propagate=False, level=ERROR) as log: - yield crawler.crawl() - log.check( - ( - "scrapy.core.engine", - "ERROR", - "Error while reading seeds", - ), - ) - class TestSitemapSpider(TestSpider): spider_class = SitemapSpider diff --git a/tests/test_spider_yield_seeds.py b/tests/test_spider_yield_seeds.py index 67b2857dd..df891ff21 100644 --- a/tests/test_spider_yield_seeds.py +++ b/tests/test_spider_yield_seeds.py @@ -220,3 +220,17 @@ class MainTestCase(TestCase): await self._test_yield_seeds(yield_seeds, [ITEM_A]) assert "in yield_seeds\n raise RuntimeError" in str(log), log + + @deferred_f_from_coro_f + async def test_start_url(self): + class TestSpider(Spider): + name = "test" + start_url = "https://toscrape.com" + + with LogCapture() as log: + await self._test_spider(TestSpider, []) + + assert "Error while reading seeds" in str(log), log + assert "found 'start_url' attribute instead, did you miss an 's'?" in str( + log + ), log