From 0d9147ea852320d7df8097d5b2d3d9548d96a32b Mon Sep 17 00:00:00 2001 From: Andrey Rakhmatullin Date: Mon, 22 Jun 2026 23:17:59 +0500 Subject: [PATCH] Close the file in test_stats_file_failed(). --- tests/test_feedexport.py | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/tests/test_feedexport.py b/tests/test_feedexport.py index 3f503cb83..d7ea60cc8 100644 --- a/tests/test_feedexport.py +++ b/tests/test_feedexport.py @@ -478,9 +478,14 @@ class TestFeedExport(TestFeedExportBase): }, } crawler = get_crawler(ItemSpider, settings) + + def store(file: IO[bytes]) -> None: + file.close() + raise KeyError("foo") + with mock.patch( "scrapy.extensions.feedexport.FileFeedStorage.store", - side_effect=KeyError("foo"), # TODO this needs file.close() + side_effect=store, ): yield crawler.crawl(mockserver=self.mockserver) assert "feedexport/failed_count/FileFeedStorage" in crawler.stats.get_stats()