From 0dc3e6350c230028addd8e73833c93341bab4b42 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Adri=C3=A1n=20Chaves?= <adrian@chaves.io>
Date: Mon, 23 Nov 2020 22:10:45 +0100
Subject: [PATCH] Add a test to check the Twisted version in pinned
 environments

---
 tests/test_dependencies.py | 32 ++++++++++++++++++++++++++++++++
 tox.ini                    | 10 ++++++++++
 2 files changed, 42 insertions(+)

diff --git a/tests/test_dependencies.py b/tests/test_dependencies.py
index 5d0a1d0c9..4e4f190ab 100644
--- a/tests/test_dependencies.py
+++ b/tests/test_dependencies.py
@@ -1,8 +1,14 @@
+import os
+import re
+from configparser import ConfigParser
 from importlib import import_module
+
+from twisted import version as twisted_version
 from twisted.trial import unittest
 
 
 class ScrapyUtilsTest(unittest.TestCase):
+
     def test_required_openssl_version(self):
         try:
             module = import_module('OpenSSL')
@@ -13,6 +19,32 @@ class ScrapyUtilsTest(unittest.TestCase):
             installed_version = [int(x) for x in module.__version__.split('.')[:2]]
             assert installed_version >= [0, 6], "OpenSSL >= 0.6 required"
 
+    def test_pinned_twisted_version(self):
+        """When running tests within a Tox environment with pinned
+        dependencies, make sure that the version of Twisted is the pinned
+        version.
+
+        See https://github.com/scrapy/scrapy/pull/4814#issuecomment-706230011
+        """
+        if not os.environ.get('SCRAPY_PINNED', None):
+            self.skipTest('Not in a pinned environment')
+
+        tox_config_file_path = os.path.join(
+            os.path.dirname(__file__),
+            '..',
+            'tox.ini',
+        )
+        config_parser = ConfigParser()
+        config_parser.read(tox_config_file_path)
+        pattern = r'Twisted==([\d.]+)'
+        match = re.search(pattern, config_parser['pinned']['deps'])
+        pinned_twisted_version_string = match[1]
+
+        self.assertEqual(
+            twisted_version.short(),
+            pinned_twisted_version_string
+        )
+
 
 if __name__ == "__main__":
     unittest.main()
diff --git a/tox.ini b/tox.ini
index 56e736fbf..ea71a2476 100644
--- a/tox.ini
+++ b/tox.ini
@@ -92,6 +92,8 @@ install_command =
     # --use-feature=2020-resolver is required, otherwise the latest verion of
     # Twisted gets installed.
     pip install --use-feature=2020-resolver {opts} {packages}
+setenv =
+    SCRAPY_PINNED=true
 
 [testenv:pinned]
 deps =
@@ -100,6 +102,8 @@ deps =
     PyDispatcher==2.0.5
 install_command =
     {[pinned]install_command}
+setenv =
+    {[pinned]setenv}
     
 [testenv:windows-pinned]
 basepython = python3
@@ -111,6 +115,8 @@ deps =
     PyDispatcher==2.0.5
 install_command =
     {[pinned]install_command}
+setenv =
+    {[pinned]setenv}
 
 [testenv:extra-deps]
 deps =
@@ -131,6 +137,8 @@ deps = {[testenv:pinned]deps}
 install_command =
     {[pinned]install_command}
 commands = {[testenv:asyncio]commands}
+setenv =
+    {[pinned]setenv}
 
 [testenv:pypy3]
 basepython = pypy3
@@ -146,6 +154,8 @@ deps =
 install_command =
     {[pinned]install_command}
 commands = {[testenv:pypy3]commands}
+setenv =
+    {[pinned]setenv}
 
 [docs]
 changedir = docs