RomanNum3ral
/
scrapy
mirror of https://github.com/scrapy/scrapy.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #4244 from wRAR/split-EngineTest 

Split a long test in test_engine.py into three.
This commit is contained in:
Andrey Rahmatullin 2019-12-18 20:00:36 +05:00 committed by GitHub
parent 053319334c 7ccb169a27
commit 0e8ee22a88
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
tests/test_engine.py
View File

@ -179,7 +179,6 @@ class EngineTest(unittest.TestCase):
@defer.inlineCallbacks @defer.inlineCallbacks
def test_crawler(self): def test_crawler(self):
for spider in TestSpider, DictItemsSpider: for spider in TestSpider, DictItemsSpider:
self.run = CrawlerRun(spider) self.run = CrawlerRun(spider)
yield self.run.run() yield self.run.run()
@ -189,11 +188,15 @@ class EngineTest(unittest.TestCase):
self._assert_scraped_items() self._assert_scraped_items()
self._assert_signals_catched() self._assert_signals_catched()
@defer.inlineCallbacks
def test_crawler_dupefilter(self):
self.run = CrawlerRun(TestDupeFilterSpider) self.run = CrawlerRun(TestDupeFilterSpider)
yield self.run.run() yield self.run.run()
self._assert_scheduled_requests(urls_to_visit=7) self._assert_scheduled_requests(urls_to_visit=7)
self._assert_dropped_requests() self._assert_dropped_requests()
@defer.inlineCallbacks
def test_crawler_itemerror(self):
self.run = CrawlerRun(ItemZeroDivisionErrorSpider) self.run = CrawlerRun(ItemZeroDivisionErrorSpider)
yield self.run.run() yield self.run.run()
self._assert_items_error() self._assert_items_error()