From 180bc9bad7aceb3a9e10c1411212914bc32fb721 Mon Sep 17 00:00:00 2001
From: aisha-partha <153170327+aisha-partha@users.noreply.github.com>
Date: Wed, 8 May 2024 22:06:46 +0530
Subject: [PATCH 1/4] =?UTF-8?q?Closes=20#6342.=20Setting=20METAREFRESH=5FI?=
 =?UTF-8?q?GNORE=5FTAGS=20to=20[=E2=80=98noscript=E2=80=99]=20by=20default?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 docs/topics/downloader-middleware.rst       | 4 ++--
 scrapy/settings/default_settings.py         | 2 +-
 tests/test_downloadermiddleware_redirect.py | 5 ++---
 3 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/docs/topics/downloader-middleware.rst b/docs/topics/downloader-middleware.rst
index 1abbc4968..3f90cf2ed 100644
--- a/docs/topics/downloader-middleware.rst
+++ b/docs/topics/downloader-middleware.rst
@@ -876,13 +876,13 @@ Whether the Meta Refresh middleware will be enabled.
 METAREFRESH_IGNORE_TAGS
 ^^^^^^^^^^^^^^^^^^^^^^^
 
-Default: ``[]``
+Default: ``['noscript']``
 
 Meta tags within these tags are ignored.
 
 .. versionchanged:: 2.0
    The default value of :setting:`METAREFRESH_IGNORE_TAGS` changed from
-   ``['script', 'noscript']`` to ``[]``.
+   ``[]`` to ``['noscript']``.
 
 .. setting:: METAREFRESH_MAXDELAY
 
diff --git a/scrapy/settings/default_settings.py b/scrapy/settings/default_settings.py
index 2b3d95a0e..d7ac7ec35 100644
--- a/scrapy/settings/default_settings.py
+++ b/scrapy/settings/default_settings.py
@@ -239,7 +239,7 @@ MEMUSAGE_NOTIFY_MAIL = []
 MEMUSAGE_WARNING_MB = 0
 
 METAREFRESH_ENABLED = True
-METAREFRESH_IGNORE_TAGS = []
+METAREFRESH_IGNORE_TAGS = ["noscript"]
 METAREFRESH_MAXDELAY = 100
 
 NEWSPIDER_MODULE = ""
diff --git a/tests/test_downloadermiddleware_redirect.py b/tests/test_downloadermiddleware_redirect.py
index 10b8ca9af..83ff25982 100644
--- a/tests/test_downloadermiddleware_redirect.py
+++ b/tests/test_downloadermiddleware_redirect.py
@@ -395,9 +395,8 @@ class MetaRefreshMiddlewareTest(unittest.TestCase):
             """content="0;URL='http://example.org/newpage'"></noscript>"""
         )
         rsp = HtmlResponse(req.url, body=body.encode())
-        req2 = self.mw.process_response(req, rsp, self.spider)
-        assert isinstance(req2, Request)
-        self.assertEqual(req2.url, "http://example.org/newpage")
+        response = self.mw.process_response(req, rsp, self.spider)
+        assert isinstance(response, Response)
 
     def test_ignore_tags_1_x_list(self):
         """Test that Scrapy 1.x behavior remains possible"""

From 3590a1f66b30edfc836b95bbd0a3611eee9371e2 Mon Sep 17 00:00:00 2001
From: aisha-partha <153170327+aisha-partha@users.noreply.github.com>
Date: Wed, 8 May 2024 23:23:17 +0530
Subject: [PATCH 2/4] Closes #6342. Update documentation on
 METAREFRESH_IGNORE_TAGS default value change

---
 docs/topics/downloader-middleware.rst | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/docs/topics/downloader-middleware.rst b/docs/topics/downloader-middleware.rst
index 3f90cf2ed..2663a3cf3 100644
--- a/docs/topics/downloader-middleware.rst
+++ b/docs/topics/downloader-middleware.rst
@@ -881,6 +881,10 @@ Default: ``['noscript']``
 Meta tags within these tags are ignored.
 
 .. versionchanged:: 2.0
+   The default value of :setting:`METAREFRESH_IGNORE_TAGS` changed from
+   ``['script', 'noscript']`` to ``[]``.
+
+.. versionchanges:: VERSION
    The default value of :setting:`METAREFRESH_IGNORE_TAGS` changed from
    ``[]`` to ``['noscript']``.
 

From 2e13a9b8e19ae1c0f595435d7d3ce096c3b29ced Mon Sep 17 00:00:00 2001
From: aisha-partha <153170327+aisha-partha@users.noreply.github.com>
Date: Wed, 8 May 2024 23:33:13 +0530
Subject: [PATCH 3/4] Update METAREFRESH_IGNORE_TAGS default value in
 documentation

---
 docs/topics/downloader-middleware.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/docs/topics/downloader-middleware.rst b/docs/topics/downloader-middleware.rst
index 2663a3cf3..01bde772c 100644
--- a/docs/topics/downloader-middleware.rst
+++ b/docs/topics/downloader-middleware.rst
@@ -876,7 +876,7 @@ Whether the Meta Refresh middleware will be enabled.
 METAREFRESH_IGNORE_TAGS
 ^^^^^^^^^^^^^^^^^^^^^^^
 
-Default: ``['noscript']``
+Default: ``[]``
 
 Meta tags within these tags are ignored.
 

From fe163d98ea81b4aff82bb9b194c4b0268c44f1db Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Adri=C3=A1n=20Chaves?= <adrian@chaves.io>
Date: Wed, 8 May 2024 20:41:20 +0200
Subject: [PATCH 4/4] Fix typo

---
 docs/topics/downloader-middleware.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/docs/topics/downloader-middleware.rst b/docs/topics/downloader-middleware.rst
index 01bde772c..d4cd062fe 100644
--- a/docs/topics/downloader-middleware.rst
+++ b/docs/topics/downloader-middleware.rst
@@ -884,7 +884,7 @@ Meta tags within these tags are ignored.
    The default value of :setting:`METAREFRESH_IGNORE_TAGS` changed from
    ``['script', 'noscript']`` to ``[]``.
 
-.. versionchanges:: VERSION
+.. versionchanged:: VERSION
    The default value of :setting:`METAREFRESH_IGNORE_TAGS` changed from
    ``[]`` to ``['noscript']``.