From 99cc853d6953d336ca65e0eecc0cb3286306bacf Mon Sep 17 00:00:00 2001
From: Eugenio Lacuesta <eugenio.lacuesta@gmail.com>
Date: Tue, 29 Sep 2020 23:53:37 -0300
Subject: [PATCH 01/15] Response.protocol attribute

---
 scrapy/core/downloader/handlers/http11.py |  1 +
 scrapy/http/response/__init__.py          | 17 ++++++++++++++---
 2 files changed, 15 insertions(+), 3 deletions(-)

diff --git a/scrapy/core/downloader/handlers/http11.py b/scrapy/core/downloader/handlers/http11.py
index 1b041c8a8..0f30b01f9 100644
--- a/scrapy/core/downloader/handlers/http11.py
+++ b/scrapy/core/downloader/handlers/http11.py
@@ -442,6 +442,7 @@ class ScrapyAgent:
             flags=result["flags"],
             certificate=result["certificate"],
             ip_address=result["ip_address"],
+            protocol=getattr(result["txresponse"], "version", None),
         )
         if result.get("failure"):
             result["failure"].value.response = response
diff --git a/scrapy/http/response/__init__.py b/scrapy/http/response/__init__.py
index c635fde69..f4ef79c72 100644
--- a/scrapy/http/response/__init__.py
+++ b/scrapy/http/response/__init__.py
@@ -17,8 +17,18 @@ from scrapy.utils.trackref import object_ref
 
 class Response(object_ref):
 
-    def __init__(self, url, status=200, headers=None, body=b'', flags=None,
-                 request=None, certificate=None, ip_address=None):
+    def __init__(
+        self,
+        url,
+        status=200,
+        headers=None,
+        body=b"",
+        flags=None,
+        request=None,
+        certificate=None,
+        ip_address=None,
+        protocol=None,
+    ):
         self.headers = Headers(headers or {})
         self.status = int(status)
         self._set_body(body)
@@ -27,6 +37,7 @@ class Response(object_ref):
         self.flags = [] if flags is None else list(flags)
         self.certificate = certificate
         self.ip_address = ip_address
+        self.protocol = protocol
 
     @property
     def cb_kwargs(self):
@@ -90,7 +101,7 @@ class Response(object_ref):
         given new values.
         """
         for x in ['url', 'status', 'headers', 'body',
-                  'request', 'flags', 'certificate', 'ip_address']:
+                  'request', 'flags', 'certificate', 'ip_address', 'protocol']:
             kwargs.setdefault(x, getattr(self, x))
         cls = kwargs.pop('cls', self.__class__)
         return cls(*args, **kwargs)

From 5b6b56240c24d02ef69e6cc591ffb2529bc3f36a Mon Sep 17 00:00:00 2001
From: Eugenio Lacuesta <eugenio.lacuesta@gmail.com>
Date: Wed, 11 Nov 2020 01:08:37 -0300
Subject: [PATCH 02/15] Test Response.protocol attribute

---
 tests/test_downloader_handlers.py | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/tests/test_downloader_handlers.py b/tests/test_downloader_handlers.py
index 3e8d7e6b9..eb6d40df7 100644
--- a/tests/test_downloader_handlers.py
+++ b/tests/test_downloader_handlers.py
@@ -489,6 +489,13 @@ class Http11TestCase(HttpTestCase):
     def test_download_broken_chunked_content_allow_data_loss_via_setting(self):
         return self.test_download_broken_content_allow_data_loss_via_setting('broken-chunked')
 
+    def test_protocol(self):
+        request = Request(self.getURL("host"), method="GET")
+        d = self.download_request(request, Spider("foo"))
+        d.addCallback(lambda r: r.protocol)
+        d.addCallback(self.assertEqual, (b"HTTP", 1, 1))
+        return d
+
 
 class Https11TestCase(Http11TestCase):
     scheme = 'https'

From 587b4dd71fca12fa5fcc766b891540af77cb27c8 Mon Sep 17 00:00:00 2001
From: Eugenio Lacuesta <eugenio.lacuesta@gmail.com>
Date: Wed, 11 Nov 2020 01:20:50 -0300
Subject: [PATCH 03/15] Docs for the Response.protocol attribute

---
 docs/topics/request-response.rst | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/docs/topics/request-response.rst b/docs/topics/request-response.rst
index f3aaa2c8f..d7d5cd44e 100644
--- a/docs/topics/request-response.rst
+++ b/docs/topics/request-response.rst
@@ -693,9 +693,22 @@ Response objects
     :param ip_address: The IP address of the server from which the Response originated.
     :type ip_address: :class:`ipaddress.IPv4Address` or :class:`ipaddress.IPv6Address`
 
+    :param protocol: A tuple containing information about the protocol that was used
+        to download the response. Taken from the ``version`` attribute of the
+        corresponding :class:`twisted.web.client.Response` object, it will tipically
+        consist of the protocol and version numbers, e.g. ``(b"HTTP", 1, 1)``
+        to represent "HTTP/1.1".
+    :type protocol: :class:`tuple`
+
+    .. versionadded:: 2.X.X
+       The ``protocol`` parameter.
+
     .. versionadded:: 2.1.0
        The ``ip_address`` parameter.
 
+    .. versionadded:: 2.0.0
+       The ``certificate`` parameter.
+
     .. attribute:: Response.url
 
         A string containing the URL of the response.
@@ -780,6 +793,8 @@ Response objects
 
     .. attribute:: Response.certificate
 
+        .. versionadded:: 2.0.0
+
         A :class:`twisted.internet.ssl.Certificate` object representing
         the server's SSL certificate.
 
@@ -795,6 +810,20 @@ Response objects
         handler, i.e. for ``http(s)`` responses. For other handlers,
         :attr:`ip_address` is always ``None``.
 
+    .. attribute:: Response.protocol
+
+        .. versionadded:: 2.X.X
+
+        A tuple containing information about the protocol that was used
+        to download the response. Taken from the ``version`` attribute of the
+        corresponding :class:`twisted.web.client.Response` object, it will tipically
+        consist of the protocol and version numbers, e.g. ``(b"HTTP", 1, 1)``
+        to represent "HTTP/1.1".
+
+        This attribute is currently only populated by the HTTP 1.1 download
+        handler, i.e. for ``http(s)`` responses. For other handlers,
+        :attr:`protocol` is always ``None``.
+
     .. method:: Response.copy()
 
        Returns a new Response which is a copy of this Response.

From 0fb7bcb2cf1606f63f1863bea254a34386c6a0f1 Mon Sep 17 00:00:00 2001
From: Eugenio Lacuesta <eugenio.lacuesta@gmail.com>
Date: Wed, 11 Nov 2020 01:26:03 -0300
Subject: [PATCH 04/15] Style adjustment

---
 scrapy/http/response/__init__.py | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/scrapy/http/response/__init__.py b/scrapy/http/response/__init__.py
index f4ef79c72..185a9bb67 100644
--- a/scrapy/http/response/__init__.py
+++ b/scrapy/http/response/__init__.py
@@ -100,8 +100,9 @@ class Response(object_ref):
         """Create a new Response with the same attributes except for those
         given new values.
         """
-        for x in ['url', 'status', 'headers', 'body',
-                  'request', 'flags', 'certificate', 'ip_address', 'protocol']:
+        for x in [
+            "url", "status", "headers", "body", "request", "flags", "certificate", "ip_address", "protocol",
+        ]:
             kwargs.setdefault(x, getattr(self, x))
         cls = kwargs.pop('cls', self.__class__)
         return cls(*args, **kwargs)

From 61d089485c7ba66649b936e34833b2013fa12458 Mon Sep 17 00:00:00 2001
From: Eugenio Lacuesta <eugenio.lacuesta@gmail.com>
Date: Wed, 11 Nov 2020 01:31:15 -0300
Subject: [PATCH 05/15] Docs: sort versionadded directives

---
 docs/topics/request-response.rst | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/docs/topics/request-response.rst b/docs/topics/request-response.rst
index d7d5cd44e..f1be41dde 100644
--- a/docs/topics/request-response.rst
+++ b/docs/topics/request-response.rst
@@ -700,14 +700,14 @@ Response objects
         to represent "HTTP/1.1".
     :type protocol: :class:`tuple`
 
-    .. versionadded:: 2.X.X
-       The ``protocol`` parameter.
+    .. versionadded:: 2.0.0
+       The ``certificate`` parameter.
 
     .. versionadded:: 2.1.0
        The ``ip_address`` parameter.
 
-    .. versionadded:: 2.0.0
-       The ``certificate`` parameter.
+    .. versionadded:: 2.X.X
+       The ``protocol`` parameter.
 
     .. attribute:: Response.url
 

From 22424125560496c9d131c9b7226aaf0f794e5ad8 Mon Sep 17 00:00:00 2001
From: Eugenio Lacuesta <eugenio.lacuesta@gmail.com>
Date: Wed, 11 Nov 2020 10:50:54 -0300
Subject: [PATCH 06/15] Docs: placeholder for versionadded directive

---
 docs/topics/request-response.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/docs/topics/request-response.rst b/docs/topics/request-response.rst
index f1be41dde..1cb724227 100644
--- a/docs/topics/request-response.rst
+++ b/docs/topics/request-response.rst
@@ -706,7 +706,7 @@ Response objects
     .. versionadded:: 2.1.0
        The ``ip_address`` parameter.
 
-    .. versionadded:: 2.X.X
+    .. versionadded:: VERSION
        The ``protocol`` parameter.
 
     .. attribute:: Response.url
@@ -812,7 +812,7 @@ Response objects
 
     .. attribute:: Response.protocol
 
-        .. versionadded:: 2.X.X
+        .. versionadded:: VERSION
 
         A tuple containing information about the protocol that was used
         to download the response. Taken from the ``version`` attribute of the

From 5e9a99e6a1e940864d9157252592f04658eaf851 Mon Sep 17 00:00:00 2001
From: Eugenio Lacuesta <eugenio.lacuesta@gmail.com>
Date: Wed, 11 Nov 2020 11:15:29 -0300
Subject: [PATCH 07/15] Reponse.protocol as string

---
 docs/topics/request-response.rst          | 20 +++++++-------------
 scrapy/core/downloader/handlers/http11.py |  7 ++++++-
 scrapy/core/downloader/webclient.py       |  4 ++--
 tests/test_downloader_handlers.py         |  9 ++++++++-
 4 files changed, 23 insertions(+), 17 deletions(-)

diff --git a/docs/topics/request-response.rst b/docs/topics/request-response.rst
index 1cb724227..98906992d 100644
--- a/docs/topics/request-response.rst
+++ b/docs/topics/request-response.rst
@@ -693,12 +693,9 @@ Response objects
     :param ip_address: The IP address of the server from which the Response originated.
     :type ip_address: :class:`ipaddress.IPv4Address` or :class:`ipaddress.IPv6Address`
 
-    :param protocol: A tuple containing information about the protocol that was used
-        to download the response. Taken from the ``version`` attribute of the
-        corresponding :class:`twisted.web.client.Response` object, it will tipically
-        consist of the protocol and version numbers, e.g. ``(b"HTTP", 1, 1)``
-        to represent "HTTP/1.1".
-    :type protocol: :class:`tuple`
+    :param protocol: The protocol that was used to download the response.
+        For instance: "HTTP/1.0", "HTTP/1.1"
+    :type protocol: :class:`str`
 
     .. versionadded:: 2.0.0
        The ``certificate`` parameter.
@@ -814,14 +811,11 @@ Response objects
 
         .. versionadded:: VERSION
 
-        A tuple containing information about the protocol that was used
-        to download the response. Taken from the ``version`` attribute of the
-        corresponding :class:`twisted.web.client.Response` object, it will tipically
-        consist of the protocol and version numbers, e.g. ``(b"HTTP", 1, 1)``
-        to represent "HTTP/1.1".
+        The protocol that was used to download the response.
+        For instance: "HTTP/1.0", "HTTP/1.1"
 
-        This attribute is currently only populated by the HTTP 1.1 download
-        handler, i.e. for ``http(s)`` responses. For other handlers,
+        This attribute is currently only populated by the HTTP download
+        handlers, i.e. for ``http(s)`` responses. For other handlers,
         :attr:`protocol` is always ``None``.
 
     .. method:: Response.copy()
diff --git a/scrapy/core/downloader/handlers/http11.py b/scrapy/core/downloader/handlers/http11.py
index 0f30b01f9..c7553eb87 100644
--- a/scrapy/core/downloader/handlers/http11.py
+++ b/scrapy/core/downloader/handlers/http11.py
@@ -434,6 +434,11 @@ class ScrapyAgent:
     def _cb_bodydone(self, result, request, url):
         headers = Headers(result["txresponse"].headers.getAllRawHeaders())
         respcls = responsetypes.from_args(headers=headers, url=url, body=result["body"])
+        try:
+            version = result["txresponse"].version
+            protocol = f"{to_unicode(version[0])}/{version[1]}.{version[2]}"
+        except (AttributeError, TypeError):
+            protocol = None
         response = respcls(
             url=url,
             status=int(result["txresponse"].code),
@@ -442,7 +447,7 @@ class ScrapyAgent:
             flags=result["flags"],
             certificate=result["certificate"],
             ip_address=result["ip_address"],
-            protocol=getattr(result["txresponse"], "version", None),
+            protocol=protocol,
         )
         if result.get("failure"):
             result["failure"].value.response = response
diff --git a/scrapy/core/downloader/webclient.py b/scrapy/core/downloader/webclient.py
index c13683393..9524cce2b 100644
--- a/scrapy/core/downloader/webclient.py
+++ b/scrapy/core/downloader/webclient.py
@@ -7,7 +7,7 @@ from twisted.internet.protocol import ClientFactory
 
 from scrapy.http import Headers
 from scrapy.utils.httpobj import urlparse_cached
-from scrapy.utils.python import to_bytes
+from scrapy.utils.python import to_bytes, to_unicode
 from scrapy.responsetypes import responsetypes
 
 
@@ -110,7 +110,7 @@ class ScrapyHTTPClientFactory(ClientFactory):
         status = int(self.status)
         headers = Headers(self.response_headers)
         respcls = responsetypes.from_args(headers=headers, url=self._url)
-        return respcls(url=self._url, status=status, headers=headers, body=body)
+        return respcls(url=self._url, status=status, headers=headers, body=body, protocol=to_unicode(self.version))
 
     def _set_connection_attributes(self, request):
         parsed = urlparse_cached(request)
diff --git a/tests/test_downloader_handlers.py b/tests/test_downloader_handlers.py
index eb6d40df7..a8763a7a5 100644
--- a/tests/test_downloader_handlers.py
+++ b/tests/test_downloader_handlers.py
@@ -360,6 +360,13 @@ class Http10TestCase(HttpTestCase):
     """HTTP 1.0 test case"""
     download_handler_cls = HTTP10DownloadHandler
 
+    def test_protocol(self):
+        request = Request(self.getURL("host"), method="GET")
+        d = self.download_request(request, Spider("foo"))
+        d.addCallback(lambda r: r.protocol)
+        d.addCallback(self.assertEqual, "HTTP/1.0")
+        return d
+
 
 class Https10TestCase(Http10TestCase):
     scheme = 'https'
@@ -493,7 +500,7 @@ class Http11TestCase(HttpTestCase):
         request = Request(self.getURL("host"), method="GET")
         d = self.download_request(request, Spider("foo"))
         d.addCallback(lambda r: r.protocol)
-        d.addCallback(self.assertEqual, (b"HTTP", 1, 1))
+        d.addCallback(self.assertEqual, "HTTP/1.1")
         return d
 
 

From b0368228d7f6391c0df41fca1609c6548613ad6b Mon Sep 17 00:00:00 2001
From: Eugenio Lacuesta <eugenio.lacuesta@gmail.com>
Date: Wed, 11 Nov 2020 11:18:03 -0300
Subject: [PATCH 08/15] Add exception to catch

---
 scrapy/core/downloader/handlers/http11.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scrapy/core/downloader/handlers/http11.py b/scrapy/core/downloader/handlers/http11.py
index c7553eb87..a0fd837b1 100644
--- a/scrapy/core/downloader/handlers/http11.py
+++ b/scrapy/core/downloader/handlers/http11.py
@@ -437,7 +437,7 @@ class ScrapyAgent:
         try:
             version = result["txresponse"].version
             protocol = f"{to_unicode(version[0])}/{version[1]}.{version[2]}"
-        except (AttributeError, TypeError):
+        except (AttributeError, TypeError, IndexError):
             protocol = None
         response = respcls(
             url=url,

From 2405df49f14cbc052d73e58a819a87417b2502e8 Mon Sep 17 00:00:00 2001
From: Eugenio Lacuesta <eugenio.lacuesta@gmail.com>
Date: Mon, 16 Nov 2020 12:50:33 -0300
Subject: [PATCH 09/15] Add tests for Response.protocol=None

---
 tests/test_downloader_handlers.py | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/tests/test_downloader_handlers.py b/tests/test_downloader_handlers.py
index a8763a7a5..f51a6cd3c 100644
--- a/tests/test_downloader_handlers.py
+++ b/tests/test_downloader_handlers.py
@@ -115,6 +115,7 @@ class FileTestCase(unittest.TestCase):
             self.assertEqual(response.url, request.url)
             self.assertEqual(response.status, 200)
             self.assertEqual(response.body, b'0123456789')
+            self.assertEqual(response.protocol, None)
 
         request = Request(path_to_file_uri(self.tmpname + '^'))
         assert request.url.upper().endswith('%5E')
@@ -976,6 +977,7 @@ class BaseFTPTestCase(unittest.TestCase):
             self.assertEqual(r.status, 200)
             self.assertEqual(r.body, b'I have the power!')
             self.assertEqual(r.headers, {b'Local Filename': [b''], b'Size': [b'17']})
+            self.assertIsNone(r.protocol)
         return self._add_test_callbacks(d, _test)
 
     def test_ftp_download_path_with_spaces(self):
@@ -1134,3 +1136,10 @@ class DataURITestCase(unittest.TestCase):
 
         request = Request('data:text/plain;base64,SGVsbG8sIHdvcmxkLg%3D%3D')
         return self.download_request(request, self.spider).addCallback(_test)
+
+    def test_protocol(self):
+        def _test(response):
+            self.assertIsNone(response.protocol)
+
+        request = Request("data:,")
+        return self.download_request(request, self.spider).addCallback(_test)

From 0dff5781bc9089884e27b0a59c1e92fc111b2817 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Adri=C3=A1n=20Chaves?= <adrian@chaves.io>
Date: Mon, 21 Dec 2020 11:13:14 +0100
Subject: [PATCH 10/15] Blind attempt to fix the build of the
 cryptography-provided OpenSSL

---
 tox.ini | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tox.ini b/tox.ini
index 6c39299bb..d3ff930c3 100644
--- a/tox.ini
+++ b/tox.ini
@@ -146,6 +146,8 @@ commands =
 
 [testenv:pypy3-pinned]
 basepython = {[testenv:pypy3]basepython}
+before_install:
+  - sudo apt-get -y remove libssl-dev
 deps =
     {[pinned]deps}
     lxml==4.0.0

From 798a818cafb21eeb62790d905d43cec678d30693 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Adri=C3=A1n=20Chaves?= <adrian@chaves.io>
Date: Mon, 21 Dec 2020 13:35:40 +0100
Subject: [PATCH 11/15] Move apt-get command from Tox to Travis CI

---
 .travis.yml | 1 +
 tox.ini     | 2 --
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/.travis.yml b/.travis.yml
index f0eafd137..055304abe 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -42,6 +42,7 @@ matrix:
       python: 3.8
       dist: bionic
 install:
+  - apt-get -y remove libssl-dev
   - |
       if [[ ! -z "$PYPY_VERSION" ]]; then
         export PYPY_VERSION="pypy$PYPY_VERSION-linux64"
diff --git a/tox.ini b/tox.ini
index d3ff930c3..6c39299bb 100644
--- a/tox.ini
+++ b/tox.ini
@@ -146,8 +146,6 @@ commands =
 
 [testenv:pypy3-pinned]
 basepython = {[testenv:pypy3]basepython}
-before_install:
-  - sudo apt-get -y remove libssl-dev
 deps =
     {[pinned]deps}
     lxml==4.0.0

From 1c1255a75d315cd535dbcc5689ddda9c80c79684 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Adri=C3=A1n=20Chaves?= <adrian@chaves.io>
Date: Mon, 21 Dec 2020 14:41:02 +0100
Subject: [PATCH 12/15] Use sudo for apt-get

---
 .travis.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.travis.yml b/.travis.yml
index 055304abe..1a296c5e6 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -42,7 +42,7 @@ matrix:
       python: 3.8
       dist: bionic
 install:
-  - apt-get -y remove libssl-dev
+  - sudo apt-get -y remove libssl-dev
   - |
       if [[ ! -z "$PYPY_VERSION" ]]; then
         export PYPY_VERSION="pypy$PYPY_VERSION-linux64"

From 45eb099ed1937a530208eb91e28e013d56b542ac Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Adri=C3=A1n=20Chaves?= <adrian@chaves.io>
Date: Mon, 21 Dec 2020 15:37:02 +0100
Subject: [PATCH 13/15] =?UTF-8?q?Maybe=20it=E2=80=99s=20about=20having=20a?=
 =?UTF-8?q?=20newer=20libssl?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 .travis.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.travis.yml b/.travis.yml
index 1a296c5e6..880c8772b 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -23,6 +23,7 @@ matrix:
     - env: TOXENV=asyncio-pinned
       python: 3.6.1
     - env: TOXENV=pypy3-pinned PYPY_VERSION=3.6-v7.2.0
+      dist: bionic
 
     - env: TOXENV=py
       python: 3.6
@@ -42,7 +43,6 @@ matrix:
       python: 3.8
       dist: bionic
 install:
-  - sudo apt-get -y remove libssl-dev
   - |
       if [[ ! -z "$PYPY_VERSION" ]]; then
         export PYPY_VERSION="pypy$PYPY_VERSION-linux64"

From b83a1a6fbfe12c205c7c57830b1d4a6fc1097be0 Mon Sep 17 00:00:00 2001
From: Eugenio Lacuesta <eugenio.lacuesta@gmail.com>
Date: Wed, 16 Dec 2020 18:02:47 -0300
Subject: [PATCH 14/15] Disable test under pypy

---
 tests/test_webclient.py | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/tests/test_webclient.py b/tests/test_webclient.py
index a60181a3a..f935a8689 100644
--- a/tests/test_webclient.py
+++ b/tests/test_webclient.py
@@ -4,7 +4,10 @@ Tests borrowed from the twisted.web.client tests.
 """
 import os
 import shutil
+import sys
+from pkg_resources import parse_version
 
+import cryptography
 import OpenSSL.SSL
 from twisted.trial import unittest
 from twisted.web import server, static, util, resource
@@ -414,6 +417,8 @@ class WebClientCustomCiphersSSLTestCase(WebClientSSLTestCase):
         ).addCallback(self.assertEqual, to_bytes(s))
 
     def testPayloadDisabledCipher(self):
+        if sys.implementation.name == "pypy" and parse_version(cryptography.__version__) <= parse_version("2.3.1"):
+            self.skipTest("This does work in PyPy with cryptography<=2.3.1")
         s = "0123456789" * 10
         settings = Settings({'DOWNLOADER_CLIENT_TLS_CIPHERS': 'ECDHE-RSA-AES256-GCM-SHA384'})
         client_context_factory = create_instance(ScrapyClientContextFactory, settings=settings, crawler=None)

From 6dccf82eaa097f9e40e922d04a8b5ec9a0a9dbd7 Mon Sep 17 00:00:00 2001
From: Tim Gates <tim.gates@iress.com>
Date: Tue, 22 Dec 2020 07:49:13 +1100
Subject: [PATCH 15/15] docs: fix simple typo, wihout -> without

There is a small typo in scrapy/http/request/form.py.

Should read `without` rather than `wihout`.
---
 scrapy/http/request/form.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scrapy/http/request/form.py b/scrapy/http/request/form.py
index 2815303a2..7f267c800 100644
--- a/scrapy/http/request/form.py
+++ b/scrapy/http/request/form.py
@@ -160,7 +160,7 @@ def _select_value(ele, n, v):
     multiple = ele.multiple
     if v is None and not multiple:
         # Match browser behaviour on simple select tag without options selected
-        # And for select tags wihout options
+        # And for select tags without options
         o = ele.value_options
         return (n, o[0]) if o else (None, None)
     elif v is not None and multiple: