From b74b98fa3e7149c27bd3a541940457864a28d5d1 Mon Sep 17 00:00:00 2001 From: Eli Atzaba Date: Tue, 16 May 2017 13:59:58 +0300 Subject: [PATCH] cleanup: removed unused MEMUSAGE_REPORT Signed-off-by: Eli Atzaba --- docs/topics/extensions.rst | 1 - docs/topics/settings.rst | 13 ------------- scrapy/extensions/memusage.py | 1 - scrapy/settings/default_settings.py | 1 - 4 files changed, 16 deletions(-) diff --git a/docs/topics/extensions.rst b/docs/topics/extensions.rst index 7f2952f4c..6036db0f5 100644 --- a/docs/topics/extensions.rst +++ b/docs/topics/extensions.rst @@ -220,7 +220,6 @@ can be configured with the following settings: * :setting:`MEMUSAGE_LIMIT_MB` * :setting:`MEMUSAGE_WARNING_MB` * :setting:`MEMUSAGE_NOTIFY_MAIL` -* :setting:`MEMUSAGE_REPORT` * :setting:`MEMUSAGE_CHECK_INTERVAL_SECONDS` Memory debugger extension diff --git a/docs/topics/settings.rst b/docs/topics/settings.rst index 9bf07588b..2cf6ffe75 100644 --- a/docs/topics/settings.rst +++ b/docs/topics/settings.rst @@ -959,19 +959,6 @@ Example:: See :ref:`topics-extensions-ref-memusage`. -.. setting:: MEMUSAGE_REPORT - -MEMUSAGE_REPORT ---------------- - -Default: ``False`` - -Scope: ``scrapy.extensions.memusage`` - -Whether to send a memory usage report after each spider has been closed. - -See :ref:`topics-extensions-ref-memusage`. - .. setting:: MEMUSAGE_WARNING_MB MEMUSAGE_WARNING_MB diff --git a/scrapy/extensions/memusage.py b/scrapy/extensions/memusage.py index 322213cf0..c0570567e 100644 --- a/scrapy/extensions/memusage.py +++ b/scrapy/extensions/memusage.py @@ -35,7 +35,6 @@ class MemoryUsage(object): self.notify_mails = crawler.settings.getlist('MEMUSAGE_NOTIFY_MAIL') self.limit = crawler.settings.getint('MEMUSAGE_LIMIT_MB')*1024*1024 self.warning = crawler.settings.getint('MEMUSAGE_WARNING_MB')*1024*1024 - self.report = crawler.settings.getbool('MEMUSAGE_REPORT') self.check_interval = crawler.settings.getfloat('MEMUSAGE_CHECK_INTERVAL_SECONDS') self.mail = MailSender.from_settings(crawler.settings) crawler.signals.connect(self.engine_started, signal=signals.engine_started) diff --git a/scrapy/settings/default_settings.py b/scrapy/settings/default_settings.py index 26ff4257e..03c36a0f9 100644 --- a/scrapy/settings/default_settings.py +++ b/scrapy/settings/default_settings.py @@ -219,7 +219,6 @@ MEMUSAGE_CHECK_INTERVAL_SECONDS = 60.0 MEMUSAGE_ENABLED = True MEMUSAGE_LIMIT_MB = 0 MEMUSAGE_NOTIFY_MAIL = [] -MEMUSAGE_REPORT = False MEMUSAGE_WARNING_MB = 0 METAREFRESH_ENABLED = True