Merge pull request #1983 from redapple/backport-1.1-pr1979

[backport][1.1] Prevent empty warnings in case of certificate verification failures (PR #1979)
2016-05-11 16:46:05 +02:00 · 2016-05-11 16:46:05 +02:00 · 1e7b216f2f
parent c9fa29cbd9 933bc8b251
commit 1e7b216f2f
1 changed files with 3 additions and 1 deletions
--- a/scrapy/core/downloader/tls.py
+++ b/scrapy/core/downloader/tls.py
@ -44,7 +44,9 @@ try:
                try:
                    verifyHostname(connection, self._hostnameASCII)
                except VerificationError as e:
-                    logger.warning(e)
+                    logger.warning(
+                        'Remote certificate is not valid for hostname "{}"; {}'.format(
+                            self._hostnameASCII, e))

 except ImportError:
    # ImportError should not matter for older Twisted versions