RomanNum3ral
/
scrapy
mirror of https://github.com/scrapy/scrapy.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #7145 from Icorebleidd/master 

Fix duplicate assertion in test_utils_deprecate
This commit is contained in:
Leonardo Tozzo 2025-11-27 21:16:02 +01:00 committed by GitHub
parent 0adc561348
commit 1e8de24380
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 0 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
tests/test_utils_deprecate.py
View File

@ -169,17 +169,12 @@ class TestWarnWhenSubclassed:
class UnrelatedClass: class UnrelatedClass:
pass pass
class OldStyleClass:
pass
assert issubclass(UpdatedUserClass1, NewName) assert issubclass(UpdatedUserClass1, NewName)
assert issubclass(UpdatedUserClass1a, NewName) assert issubclass(UpdatedUserClass1a, NewName)
assert issubclass(UpdatedUserClass1, DeprecatedName) assert issubclass(UpdatedUserClass1, DeprecatedName)
assert issubclass(UpdatedUserClass1a, DeprecatedName) assert issubclass(UpdatedUserClass1a, DeprecatedName)
assert issubclass(OutdatedUserClass1, DeprecatedName) assert issubclass(OutdatedUserClass1, DeprecatedName)
assert not issubclass(UnrelatedClass, DeprecatedName) assert not issubclass(UnrelatedClass, DeprecatedName)
assert not issubclass(OldStyleClass, DeprecatedName)
assert not issubclass(OldStyleClass, DeprecatedName)
assert not issubclass(OutdatedUserClass1, OutdatedUserClass1a) assert not issubclass(OutdatedUserClass1, OutdatedUserClass1a)
assert not issubclass(OutdatedUserClass1a, OutdatedUserClass1) assert not issubclass(OutdatedUserClass1a, OutdatedUserClass1)
@ -206,9 +201,6 @@ class TestWarnWhenSubclassed:
class UnrelatedClass: class UnrelatedClass:
pass pass
class OldStyleClass:
pass
assert isinstance(UpdatedUserClass2(), NewName) assert isinstance(UpdatedUserClass2(), NewName)
assert isinstance(UpdatedUserClass2a(), NewName) assert isinstance(UpdatedUserClass2a(), NewName)
assert isinstance(UpdatedUserClass2(), DeprecatedName) assert isinstance(UpdatedUserClass2(), DeprecatedName)
@ -218,7 +210,6 @@ class TestWarnWhenSubclassed:
assert not isinstance(OutdatedUserClass2a(), OutdatedUserClass2) assert not isinstance(OutdatedUserClass2a(), OutdatedUserClass2)
assert not isinstance(OutdatedUserClass2(), OutdatedUserClass2a) assert not isinstance(OutdatedUserClass2(), OutdatedUserClass2a)
assert not isinstance(UnrelatedClass(), DeprecatedName) assert not isinstance(UnrelatedClass(), DeprecatedName)
assert not isinstance(OldStyleClass(), DeprecatedName)
def test_clsdict(self): def test_clsdict(self):
with warnings.catch_warnings(): with warnings.catch_warnings():