Fixed logging of "Spider closed" message in engine

2009-11-26 19:12:33 -02:00 · 2009-11-26 19:12:33 -02:00 · 207aae2b04
parent 34fcf6ba5b
commit 207aae2b04
1 changed files with 3 additions and 1 deletions
--- a/scrapy/core/engine.py
+++ b/scrapy/core/engine.py
@ -312,7 +312,9 @@ class ExecutionEngine(object):
        if call and call.active():
            call.cancel()
        dfd = defer.maybeDeferred(spiders.close_spider, spider)
-        dfd.addBoth(log.msg, "Spider closed (%s)" % reason, spider=spider)
+        dfd.addErrback(log.err, "Unhandled error on SpiderManager.close_spider()",
+            spider=spider)
+        dfd.addBoth(lambda _: log.msg("Spider closed (%s)" % reason, spider=spider))
        reactor.callLater(0, self._mainloop)
        return dfd