RomanNum3ral
/
scrapy
mirror of https://github.com/scrapy/scrapy.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Improve test reliability

This commit is contained in:
Adrián Chaves 2025-03-19 20:25:55 +01:00
parent 193f170df9
commit 220c70bc0c
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
tests/test_engine_loop.py
View File

@ -31,8 +31,8 @@ class MainTestCase(TestCase):
name = "test"
async def yield_seeds(self):
self.crawler.engine._slot.scheduler.enqueue_request(Request("data:,b"))
yield Request("data:,a")
self.crawler.engine._slot.scheduler.enqueue_request(Request("data:,b"))
def parse(self, response):
pass
@ -137,8 +137,8 @@ class MainTestCase(TestCase):
name = "test"
async def yield_seeds(self):
self.crawler.engine._slot.scheduler.enqueue_request(Request("data:,b"))
yield Request("data:,a")
self.crawler.engine._slot.scheduler.enqueue_request(Request("data:,b"))
raise RuntimeError
def parse(self, response):
@ -198,9 +198,8 @@ class MainTestCase(TestCase):
name = "test"
async def yield_seeds(self):
self.crawler.engine._slot.scheduler.pause = False
yield Request("data:,a")
yield Request("data:,c")
self.crawler.engine._slot.scheduler.pause = False
def parse(self, response):
pass
@ -216,7 +215,7 @@ class MainTestCase(TestCase):
with LogCapture() as log:
await maybe_deferred_to_future(crawler.crawl())
assert crawler.stats.get_value("finish_reason") == "finished"
expected_urls = ["data:,a", "data:,b", "data:,c"]
expected_urls = ["data:,a", "data:,b"]
assert actual_urls == expected_urls, (
f"{actual_urls=} != {expected_urls=}\n{log}"
)