From 233069fc7ff3156fb51054d42ecea71fce581a94 Mon Sep 17 00:00:00 2001 From: aliowka Date: Wed, 17 Jun 2026 11:08:08 +0300 Subject: [PATCH] Add delta push after every delta run in tox environments MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Envs that use {[testenv]commands} or {[min]commands} substitution with extra pytest args (--reactor=default, -p no:twisted --reactor=none) were expanded explicitly to prevent extra args being appended to delta push. Affected environments: - [testenv] → delta run + delta push - [min] → delta run + delta push - [testenv:default-reactor] → expanded, delta push added - [testenv:min-default-reactor] → expanded, delta push added - [testenv:no-reactor] → expanded, delta push added - [testenv:no-reactor-extra-deps] → expanded, delta push added - [testenv:min-no-reactor] → expanded, delta push added --- tox.ini | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/tox.ini b/tox.ini index 2f2cb2200..c2d49fab8 100644 --- a/tox.ini +++ b/tox.ini @@ -67,6 +67,7 @@ passenv = download = true commands = delta run -- {posargs:--cov-config=pyproject.toml --cov=scrapy --cov-report= --cov-report=term-missing --cov-report=xml --junitxml=testenv.junit.xml -o junit_family=legacy --durations=10 tests --doctest-modules} + delta push [testenv:mypy] basepython = python3.10 @@ -164,6 +165,7 @@ setenv = _SCRAPY_MIN=true commands = delta run -- {posargs:--cov-config=pyproject.toml --cov=scrapy --cov-report=xml --cov-report= --junitxml=min.junit.xml -o junit_family=legacy --durations=10 scrapy tests} + delta push [testenv:min] basepython = {[min]basepython} @@ -213,12 +215,15 @@ commands = {[min]commands} [testenv:default-reactor] commands = - {[testenv]commands} --reactor=default + delta run -- {posargs:--cov-config=pyproject.toml --cov=scrapy --cov-report= --cov-report=term-missing --cov-report=xml --junitxml=testenv.junit.xml -o junit_family=legacy --durations=10 tests --doctest-modules} --reactor=default + delta push [testenv:min-default-reactor] basepython = {[min]basepython} deps = {[testenv:min]deps} -commands = {[min]commands} --reactor=default +commands = + delta run -- {posargs:--cov-config=pyproject.toml --cov=scrapy --cov-report=xml --cov-report= --junitxml=min.junit.xml -o junit_family=legacy --durations=10 scrapy tests} --reactor=default + delta push setenv = {[min]setenv} @@ -227,21 +232,25 @@ deps = {[testenv]deps} pytest-asyncio commands = - {[testenv]commands} -p no:twisted --reactor=none + delta run -- {posargs:--cov-config=pyproject.toml --cov=scrapy --cov-report= --cov-report=term-missing --cov-report=xml --junitxml=testenv.junit.xml -o junit_family=legacy --durations=10 tests --doctest-modules} -p no:twisted --reactor=none + delta push [testenv:no-reactor-extra-deps] deps = {[testenv:extra-deps]deps} pytest-asyncio commands = - {[testenv]commands} -p no:twisted --reactor=none + delta run -- {posargs:--cov-config=pyproject.toml --cov=scrapy --cov-report= --cov-report=term-missing --cov-report=xml --junitxml=testenv.junit.xml -o junit_family=legacy --durations=10 tests --doctest-modules} -p no:twisted --reactor=none + delta push [testenv:min-no-reactor] basepython = {[min]basepython} deps = {[testenv:min]deps} pytest-asyncio -commands = {[min]commands} -p no:twisted --reactor=none +commands = + delta run -- {posargs:--cov-config=pyproject.toml --cov=scrapy --cov-report=xml --cov-report= --junitxml=min.junit.xml -o junit_family=legacy --durations=10 scrapy tests} -p no:twisted --reactor=none + delta push setenv = {[min]setenv}