From 23e571e860729fad1f4351cde69b77d88837e628 Mon Sep 17 00:00:00 2001 From: colinmorris Date: Tue, 31 Oct 2017 18:08:47 -0400 Subject: [PATCH] fix issues identified in review --- docs/topics/exporters.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/topics/exporters.rst b/docs/topics/exporters.rst index 28f5ad9c2..95f7920f8 100644 --- a/docs/topics/exporters.rst +++ b/docs/topics/exporters.rst @@ -49,14 +49,14 @@ value of one of their fields:: self.year_to_exporter = {} def close_spider(self, spider): - for exporter in self.year_to_exporter.itervalues(): + for exporter in self.year_to_exporter.values(): exporter.finish_exporting() exporter.file.close() def _exporter_for_item(self, item): year = item['year'] if year not in self.year_to_exporter: - f = open('{}.xml'.format(year), 'w+b') + f = open('{}.xml'.format(year), 'wb') exporter = XmlItemExporter(f) exporter.start_exporting() self.year_to_exporter[year] = exporter