Merge pull request #5756 from Laerte/fix-test_follow_whitespace-tests

fix test_follow_whitespace_* tests
This commit is contained in:
Andrey Rahmatullin 2022-12-12 23:49:23 +05:00 committed by GitHub
commit 26ebdbf4ef
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 19 additions and 6 deletions

View File

@ -2,14 +2,17 @@ import codecs
import unittest
from unittest import mock
from packaging.version import Version as parse_version
from pytest import mark
from w3lib import __version__ as w3lib_version
from w3lib.encoding import resolve_encoding
from scrapy.http import (Request, Response, TextResponse, HtmlResponse,
XmlResponse, Headers)
from scrapy.exceptions import NotSupported
from scrapy.http import (Headers, HtmlResponse, Request, Response,
TextResponse, XmlResponse)
from scrapy.link import Link
from scrapy.selector import Selector
from scrapy.utils.python import to_unicode
from scrapy.exceptions import NotSupported
from scrapy.link import Link
from tests import get_testdata
@ -179,13 +182,23 @@ class BaseResponseTest(unittest.TestCase):
r = self.response_class("http://example.com")
self.assertRaises(ValueError, r.follow, None)
@mark.xfail(
parse_version(w3lib_version) < parse_version("2.1.1"),
reason="https://github.com/scrapy/w3lib/pull/207",
strict=True,
)
def test_follow_whitespace_url(self):
self._assert_followed_url('foo ',
'http://example.com/foo%20')
'http://example.com/foo')
@mark.xfail(
parse_version(w3lib_version) < parse_version("2.1.1"),
reason="https://github.com/scrapy/w3lib/pull/207",
strict=True,
)
def test_follow_whitespace_link(self):
self._assert_followed_url(Link('http://example.com/foo '),
'http://example.com/foo%20')
'http://example.com/foo')
def test_follow_flags(self):
res = self.response_class('http://example.com/')