From 2909a60e95e1350415358bca8efe526c9a3f0c72 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Gra=C3=B1a?= Date: Mon, 5 Mar 2012 17:49:57 -0200 Subject: [PATCH] test that default start_request return value type is a generator. refs #98 --- scrapy/tests/test_spider.py | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/scrapy/tests/test_spider.py b/scrapy/tests/test_spider.py index 9ab5dee33..bca8de4b9 100644 --- a/scrapy/tests/test_spider.py +++ b/scrapy/tests/test_spider.py @@ -1,4 +1,4 @@ -import gzip, warnings +import gzip, warnings, inspect from cStringIO import StringIO from twisted.trial import unittest @@ -24,6 +24,12 @@ class BaseSpiderTest(unittest.TestCase): self.assertEqual(spider.name, 'example.com') self.assertEqual(spider.start_urls, []) + def test_start_requests(self): + spider = self.spider_class('example.com') + start_requests = spider.start_requests() + self.assertTrue(inspect.isgenerator(start_requests)) + self.assertEqual(list(start_requests), []) + def test_spider_args(self): """Constructor arguments are assigned to spider attributes""" spider = self.spider_class('example.com', foo='bar')