From 2a7b41cdb2b5dd41391eb2fccdd675cdbd8af833 Mon Sep 17 00:00:00 2001 From: Pablo Hoffman Date: Thu, 15 Jan 2009 00:10:31 +0000 Subject: [PATCH] removed referer argument from Request constructor. refs #48 --HG-- extra : convert_revision : svn%3Ab85faa78-f9eb-468e-a121-7cced6da292c%40731 --- scrapy/trunk/scrapy/http/request.py | 5 +---- scrapy/trunk/scrapy/tests/test_http_request.py | 3 --- 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/scrapy/trunk/scrapy/http/request.py b/scrapy/trunk/scrapy/http/request.py index 06d0b9f24..eb9420fe5 100644 --- a/scrapy/trunk/scrapy/http/request.py +++ b/scrapy/trunk/scrapy/http/request.py @@ -11,7 +11,7 @@ from scrapy.utils.defer import chain_deferred class Request(object): def __init__(self, url, callback=None, context=None, method='GET', - body=None, headers=None, cookies=None, referer=None, + body=None, headers=None, cookies=None, url_encoding='utf-8', link_text='', dont_filter=None, domain=None): self.encoding = url_encoding # this one has to be set first @@ -37,9 +37,6 @@ class Request(object): self.context = context or {} # dont_filter be filtered by scheduler self.dont_filter = dont_filter - # shortcut for setting referer - if referer is not None: - self.headers['referer'] = referer self.depth = 0 self.link_text = link_text #allows to directly specify the spider for the request diff --git a/scrapy/trunk/scrapy/tests/test_http_request.py b/scrapy/trunk/scrapy/tests/test_http_request.py index c036c4196..07782d0fd 100644 --- a/scrapy/trunk/scrapy/tests/test_http_request.py +++ b/scrapy/trunk/scrapy/tests/test_http_request.py @@ -42,9 +42,6 @@ class RequestTest(unittest.TestCase): self.assert_(isinstance(k, str)) self.assert_(isinstance(v, str)) - r = Request(url="http://www.example.org/1", referer=u"http://www.example.org") - self.assert_(isinstance(r.headers['referer'], str)) - def test_eq(self): url = 'http://www.scrapy.org' r1 = Request(url=url)