From 425e35ee9023f5a973869d7e0d926297d9f75c35 Mon Sep 17 00:00:00 2001 From: Daniel Collins Date: Sat, 29 Aug 2015 12:29:01 -0700 Subject: [PATCH] removed commented code and add test for error handling --- scrapy/loader/__init__.py | 3 --- tests/test_loader.py | 5 +++++ 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/scrapy/loader/__init__.py b/scrapy/loader/__init__.py index 102ffc351..f2c43ab4c 100644 --- a/scrapy/loader/__init__.py +++ b/scrapy/loader/__init__.py @@ -115,9 +115,6 @@ class ItemLoader(object): if value is not None: item[field_name] = value - # for loader in self._subloaders: - # loader.load_item() - return item def get_output_value(self, field_name): diff --git a/tests/test_loader.py b/tests/test_loader.py index 2d34da810..90273c2c8 100644 --- a/tests/test_loader.py +++ b/tests/test_loader.py @@ -707,6 +707,11 @@ class SubselectorLoaderTest(unittest.TestCase): self.assertEqual(item['url'], [u'http://www.scrapy.org']) self.assertEqual(item['image'], [u'/images/logo.png']) + def test_nested_bad_arguments(self): + l = NestedItemLoader(response=self.response) + with self.assertRaises(ValueError): + l.nested_loader(css="#id", xpath="//footer") + class SelectJmesTestCase(unittest.TestCase): test_list_equals = {