RomanNum3ral
/
scrapy
mirror of https://github.com/scrapy/scrapy.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

make sure get_vmvalue_from_procfs returns int

This commit is contained in:
Pablo Hoffman 2009-08-18 00:59:32 -03:00
parent 49cc1b1e7e
commit 4b910881da
2 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
scrapy/tests/test_utils_memory.py
View File

@ -11,9 +11,10 @@ class UtilsMemoryTestCase(unittest.TestCase):
raise unittest.SkipTest('/proc filesystem not supported')
vmsize = get_vmvalue_from_procfs('VmSize')
vmrss = get_vmvalue_from_procfs('VmRSS')
assert vmsize > 0
assert vmrss > 0
assert vmsize > vmrss
self.assert_(isinstance(vmsize, int))
self.assert_(vmsize > 0)
self.assert_(vmrss > 0)
self.assert_(vmsize > vmrss)
if __name__ == "__main__":
unittest.main()

2
scrapy/utils/memory.py
View File

@ -21,5 +21,5 @@ def get_vmvalue_from_procfs(vmkey='VmSize', pid=None):
if len(v) < 3:
return 0 # invalid format?
# convert Vm value to bytes
return float(v[1]) * _vmvalue_scale[v[2]]
return int(v[1]) * _vmvalue_scale[v[2]]