From 4d4a04f3189fe2f36574a593814dc17319c4a66a Mon Sep 17 00:00:00 2001 From: Andrey Rakhmatullin Date: Tue, 21 Jul 2026 13:17:56 +0500 Subject: [PATCH] Improve a flaky test_stacktracedump_dump_stacktrace(). (#7753) --- tests/test_extension_debug.py | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/tests/test_extension_debug.py b/tests/test_extension_debug.py index a54807c1c..27554116b 100644 --- a/tests/test_extension_debug.py +++ b/tests/test_extension_debug.py @@ -69,14 +69,16 @@ def test_stacktracedump_dump_stacktrace(caplog: pytest.LogCaptureFixture) -> Non spider = DefaultSpider() with caplog.at_level(logging.INFO, logger="scrapy.extensions.debug"): ext.dump_stacktrace(0, None) - assert len(caplog.records) == 1 - message = caplog.records[0].getMessage() - assert "Dumping stack trace and engine status" in message - assert "Execution engine status" in message - assert "Live References" in message - assert type(spider).__name__ in message - assert "# Thread: MainThread" in message - assert getattr(caplog.records[0], "crawler", None) is crawler + for r in caplog.records: + message = r.getMessage() + if "Dumping stack trace and engine status" in message: + assert "Execution engine status" in message + assert "Live References" in message + assert type(spider).__name__ in message + assert "# Thread: MainThread" in message + assert getattr(r, "crawler", None) is crawler + return + raise AssertionError("No stack trace dump log message found") def test_stacktracedump_thread_stacks() -> None: