RomanNum3ral
/
scrapy
mirror of https://github.com/scrapy/scrapy.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

pipeline process_item methods decorated with inlineCallbacks fails because of backwards compatible change to support inverted arguments

This commit is contained in:
Daniel Grana 2010-08-18 13:05:50 -03:00
parent 50f2236d04
commit 5522afca8d
1 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
scrapy/contrib/pipeline/__init__.py
View File

@ -6,6 +6,7 @@ See documentation in docs/item-pipeline.rst
from scrapy import log
from scrapy.middleware import MiddlewareManager
from scrapy.utils.python import get_func_args
class ItemPipelineManager(MiddlewareManager):
@ -23,14 +24,14 @@ class ItemPipelineManager(MiddlewareManager):
def _add_middleware(self, pipe):
super(ItemPipelineManager, self)._add_middleware(pipe)
if hasattr(pipe, 'process_item'):
func = getattr(pipe, 'process_item', None)
if func:
# FIXME: remove in Scrapy 0.11
from scrapy.utils.python import get_func_args
if get_func_args(pipe.process_item.im_func)[1] == 'spider':
fargs = get_func_args(func.im_func)
if fargs and fargs[1] == 'spider':
log.msg("Update %s.process_item() method to receive (item, spider) instead of (spider, item) or they will stop working on Scrapy 0.11" % pipe.__class__.__name__, log.WARNING)
pipe.process_item = self._wrap_old_process_item(pipe.process_item)
self.methods['process_item'].append(pipe.process_item)
func = self._wrap_old_process_item(func)
self.methods['process_item'].append(func)
def process_item(self, item, spider):
return self._process_chain('process_item', item, spider)