RomanNum3ral
/
scrapy
mirror of https://github.com/scrapy/scrapy.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fixing oversight from #7036 (#7367) 

https://github.com/scrapy/scrapy/pull/7269#issuecomment-3958535816
This commit is contained in:
Albert Eduardovich N. 2026-03-27 13:38:44 +03:00 committed by GitHub
parent a8e99aeb2e
commit 5561aaec1d
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 0 additions and 32 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
scrapy/http/request/__init__.py
View File

@ -242,20 +242,12 @@ class Request(object_ref):
self._cb_kwargs = {}
return self._cb_kwargs
@cb_kwargs.setter
def cb_kwargs(self, value: dict[str, Any] | None) -> None:
self._cb_kwargs = value or None
@property
def meta(self) -> dict[str, Any]:
if self._meta is None:
self._meta = {}
return self._meta
@meta.setter
def meta(self, value: dict[str, Any] | None) -> None:
self._meta = value or None
@property
def url(self) -> str:
return self._url

24
tests/test_http_request.py
View File

@ -320,12 +320,6 @@ class TestRequest:
def test_setters(self):
request = self.request_class("http://example.com")
request.cb_kwargs = {"a": 1}
assert request.cb_kwargs == {"a": 1}
request.meta = {"k": "v"}
assert request.meta == {"k": "v"}
request.flags = ["f1"]
assert request.flags == ["f1"]
@ -349,24 +343,6 @@ class TestRequest:
request = self.request_class("http://example.com")
assert request._cb_kwargs is None
assert request.cb_kwargs == {}
assert request.cb_kwargs is request.cb_kwargs
assert request._cb_kwargs == {}
original_cb_kwargs = request.cb_kwargs
request.cb_kwargs = None
assert request.cb_kwargs == {}
assert request.cb_kwargs is not original_cb_kwargs
assert request._meta is None
assert request.meta == {}
assert request.meta is request.meta
assert request._meta == {}
original_meta = request.meta
request.meta = None
assert request.meta == {}
assert request.meta is not original_meta
assert request._flags is None
assert request.flags == []
assert request.flags is request.flags