RomanNum3ral
/
scrapy
mirror of https://github.com/scrapy/scrapy.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Cache resolution only if the DNS request was successful

This commit is contained in:
Eugenio Lacuesta 2020-01-15 12:25:20 -03:00
parent f1c184631e
commit 55babf9acd
No known key found for this signature in database
GPG Key ID: DA3EF2D0913E9810
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
scrapy/resolver.py
View File

@ -10,7 +10,7 @@ dnscache = LocalCache(10000)
@implementer(IHostnameResolver)
class CachingHostnameResolver(object):
class CachingHostnameResolver:
def __init__(self, resolver, cache_size, timeout):
self.resolver = resolver
@ -25,15 +25,21 @@ class CachingHostnameResolver(object):
def __init__(self, timeout):
self.timeout = timeout
self.resolved = False
def resolutionBegan(self, resolution):
super(CachingResolutionReceiver, self).resolutionBegan(resolution)
self.resolution = resolution
# reactor.callLater(self.timeout, resolution.cancel)
def addressResolved(self, address):
super(CachingResolutionReceiver, self).addressResolved(address)
self.resolved = True
def resolutionComplete(self):
super(CachingResolutionReceiver, self).resolutionComplete()
dnscache[hostName] = self.resolution
if self.resolved:
dnscache[hostName] = self.resolution
try:
result = dnscache[hostName]