From 5650de3f37c3b9865176b0b65a39ed93e2a5e2ec Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Adri=C3=A1n=20Chaves?= Date: Sun, 9 Mar 2025 09:56:54 +0100 Subject: [PATCH] Fix typing issues --- scrapy/commands/check.py | 2 +- scrapy/commands/fetch.py | 4 ++-- scrapy/core/spidermw.py | 4 +++- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/scrapy/commands/check.py b/scrapy/commands/check.py index 1982d25c5..18eeebb7d 100644 --- a/scrapy/commands/check.py +++ b/scrapy/commands/check.py @@ -89,7 +89,7 @@ class Command(ScrapyCommand): for spidername in args or spider_loader.list(): spidercls = spider_loader.load(spidername) - spidercls._result = result # type: ignore[assignment,method-assign,return-value] + spidercls._result = result # type: ignore[assignment,attr-defined,method-assign,return-value] spidercls.yield_seeds = yield_seeds # type: ignore[assignment,method-assign,return-value] tested_methods = conman.tested_methods_from_spidercls(spidercls) diff --git a/scrapy/commands/fetch.py b/scrapy/commands/fetch.py index 97eeeffa1..d1b0974ec 100644 --- a/scrapy/commands/fetch.py +++ b/scrapy/commands/fetch.py @@ -93,8 +93,8 @@ class Command(ScrapyCommand): async def yield_seeds(self): yield self._request - spidercls._request = request # type: ignore[assignment] - spidercls.yield_seeds = yield_seeds + spidercls._request = request # type: ignore[assignment,attr-defined] + spidercls.yield_seeds = yield_seeds # type: ignore[method-assign,attr-defined] self.crawler_process.crawl(spidercls) self.crawler_process.start() diff --git a/scrapy/core/spidermw.py b/scrapy/core/spidermw.py index 7a6d9bafe..188b8dcba 100644 --- a/scrapy/core/spidermw.py +++ b/scrapy/core/spidermw.py @@ -325,7 +325,9 @@ class SpiderMiddlewareManager(MiddlewareManager): return dfd2 @inlineCallbacks - def process_seeds(self, spider: Spider) -> Deferred[AsyncIterator[Any]]: + def process_seeds( + self, spider: Spider + ) -> Generator[Deferred[Any], Any, AsyncIterator[Any]]: self._check_deprecated_start_requests_use(spider) seeds = yield self._iter_seeds(spider) seeds = yield self._process_chain("process_seeds", seeds)