From 57c7c5e9f626dab4974b9de5fa99b6ca56390cfc Mon Sep 17 00:00:00 2001 From: Daniel Grana Date: Mon, 2 Mar 2009 15:37:57 +0000 Subject: [PATCH] images: log a short message when images request is ignored to dupefilter --HG-- extra : convert_revision : svn%3Ab85faa78-f9eb-468e-a121-7cced6da292c%40950 --- scrapy/trunk/scrapy/contrib/pipeline/images.py | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/scrapy/trunk/scrapy/contrib/pipeline/images.py b/scrapy/trunk/scrapy/contrib/pipeline/images.py index 95ce8e144..b026514a0 100644 --- a/scrapy/trunk/scrapy/contrib/pipeline/images.py +++ b/scrapy/trunk/scrapy/contrib/pipeline/images.py @@ -11,7 +11,7 @@ import Image from scrapy import log from scrapy.stats import stats from scrapy.core.exceptions import DropItem, NotConfigured -from scrapy.core.exceptions import HttpException +from scrapy.core.exceptions import HttpException, IgnoreRequest from scrapy.conf import settings from scrapy.contrib.pipeline.media import MediaPipeline @@ -47,7 +47,11 @@ class BaseImagesPipeline(MediaPipeline): def media_failed(self, failure, request, info): referer = request.headers.get('Referer') - errmsg = str(failure.value) if isinstance(failure.value, HttpException) else str(failure) + if isinstance(failure.value, (HttpException, IgnoreRequest)): + errmsg = str(failure.value) + else: + errmsg = str(failure) + msg = 'Image (http-error): Error downloading %s from %s referred in <%s>: %s' \ % (self.MEDIA_TYPE, request, referer, errmsg) log.msg(msg, level=log.WARNING, domain=info.domain)