From 60c2ef86f0c40d17219d3e3320072fb5b1ded412 Mon Sep 17 00:00:00 2001
From: Eugenio Lacuesta <eugenio.lacuesta@gmail.com>
Date: Sun, 15 Jul 2018 16:47:55 -0300
Subject: [PATCH] Revert "Default values for OffsiteMiddleware"

This reverts commit ba294351381c0dd81476603246d2cea6c31486be.
---
 scrapy/spidermiddlewares/offsite.py | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/scrapy/spidermiddlewares/offsite.py b/scrapy/spidermiddlewares/offsite.py
index 3b7f194e4..310166cad 100644
--- a/scrapy/spidermiddlewares/offsite.py
+++ b/scrapy/spidermiddlewares/offsite.py
@@ -19,9 +19,6 @@ class OffsiteMiddleware(object):
 
     def __init__(self, stats):
         self.stats = stats
-        # default values
-        self.host_regex = re.compile('')  # allow all by default
-        self.domains_seen = set()
 
     @classmethod
     def from_crawler(cls, crawler):
@@ -55,7 +52,7 @@ class OffsiteMiddleware(object):
         """Override this method to implement a different offsite policy"""
         allowed_domains = getattr(spider, 'allowed_domains', None)
         if not allowed_domains:
-            return
+            return re.compile('') # allow all by default
         url_pattern = re.compile("^https?://.*$")
         for domain in allowed_domains:
             if url_pattern.match(domain):
@@ -65,9 +62,8 @@ class OffsiteMiddleware(object):
         return re.compile(regex)
 
     def spider_opened(self, spider):
-        host_regex = self.get_host_regex(spider)
-        if host_regex:
-            self.host_regex = host_regex
+        self.host_regex = self.get_host_regex(spider)
+        self.domains_seen = set()
 
 
 class URLWarning(Warning):