From 63acd0720970c87450fdbcb9aa6967118c9c1cf2 Mon Sep 17 00:00:00 2001
From: Laerte Pereira <laertefbk@gmail.com>
Date: Wed, 28 Feb 2024 16:14:08 -0300
Subject: [PATCH] Fix and re-enable unnecessary-comprehension and
 use-dict-literal pylint tags

---
 pylintrc                                        | 2 --
 scrapy/downloadermiddlewares/httpcompression.py | 2 +-
 scrapy/spiders/crawl.py                         | 2 +-
 scrapy/utils/python.py                          | 2 +-
 4 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/pylintrc b/pylintrc
index 78004e78a..c60e4e16a 100644
--- a/pylintrc
+++ b/pylintrc
@@ -68,7 +68,6 @@ disable=abstract-method,
         too-many-public-methods,
         too-many-return-statements,
         unbalanced-tuple-unpacking,
-        unnecessary-comprehension,
         unnecessary-dunder-call,
         unnecessary-pass,
         unreachable,
@@ -77,7 +76,6 @@ disable=abstract-method,
         unused-private-member,
         unused-variable,
         unused-wildcard-import,
-        use-dict-literal,
         used-before-assignment,
         useless-return,
         wildcard-import,
diff --git a/scrapy/downloadermiddlewares/httpcompression.py b/scrapy/downloadermiddlewares/httpcompression.py
index f0ad24f72..aa3abe853 100644
--- a/scrapy/downloadermiddlewares/httpcompression.py
+++ b/scrapy/downloadermiddlewares/httpcompression.py
@@ -135,7 +135,7 @@ class HttpCompressionMiddleware:
                 respcls = responsetypes.from_args(
                     headers=response.headers, url=response.url, body=decoded_body
                 )
-                kwargs = dict(cls=respcls, body=decoded_body)
+                kwargs = {"cls": respcls, "body": decoded_body}
                 if issubclass(respcls, TextResponse):
                     # force recalculating the encoding until we make sure the
                     # responsetypes guessing is reliable
diff --git a/scrapy/spiders/crawl.py b/scrapy/spiders/crawl.py
index ebb4f5984..2a3913da5 100644
--- a/scrapy/spiders/crawl.py
+++ b/scrapy/spiders/crawl.py
@@ -85,7 +85,7 @@ class CrawlSpider(Spider):
             url=link.url,
             callback=self._callback,
             errback=self._errback,
-            meta=dict(rule=rule_index, link_text=link.text),
+            meta={"rule": rule_index, "link_text": link.text},
         )
 
     def _requests_to_follow(self, response):
diff --git a/scrapy/utils/python.py b/scrapy/utils/python.py
index 7b408c49c..1e7364e49 100644
--- a/scrapy/utils/python.py
+++ b/scrapy/utils/python.py
@@ -162,7 +162,7 @@ def re_rsearch(
         pattern = re.compile(pattern)
 
     for chunk, offset in _chunk_iter():
-        matches = [match for match in pattern.finditer(chunk)]
+        matches = list(pattern.finditer(chunk))
         if matches:
             start, end = matches[-1].span()
             return offset + start, offset + end