RomanNum3ral
/
scrapy
mirror of https://github.com/scrapy/scrapy.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix settings usage across tests

This commit is contained in:
Julia Medina 2014-06-09 16:51:25 -03:00
parent 43ae69e436
commit 6730e3c9f7
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
scrapy/tests/test_cmdline/extensions.py
View File

@ -3,7 +3,7 @@
class TestExtension(object):
def __init__(self, settings):
settings.overrides['TEST1'] = "%s + %s" % (settings['TEST1'], 'started')
settings.set('TEST1', "%s + %s" % (settings['TEST1'], 'started'))
@classmethod
def from_crawler(cls, crawler):

8
scrapy/tests/test_downloadermiddleware_robotstxt.py
View File

@ -6,17 +6,17 @@ from twisted.trial import unittest
from scrapy.contrib.downloadermiddleware.robotstxt import RobotsTxtMiddleware
from scrapy.exceptions import IgnoreRequest, NotConfigured
from scrapy.http import Request, Response
from scrapy.settings import CrawlerSettings
from scrapy.settings import Settings
class RobotsTxtMiddlewareTest(unittest.TestCase):
def test(self):
crawler = mock.MagicMock()
crawler.settings = CrawlerSettings()
crawler.settings.overrides['USER_AGENT'] = 'CustomAgent'
crawler.settings = Settings()
crawler.settings.set('USER_AGENT', 'CustomAgent')
self.assertRaises(NotConfigured, RobotsTxtMiddleware, crawler)
crawler.settings.overrides['ROBOTSTXT_OBEY'] = True
crawler.settings.set('ROBOTSTXT_OBEY', True)
crawler.engine.download = mock.MagicMock()
ROBOTS = re.sub(r'^\s+(?m)', '', '''
User-Agent: *