RomanNum3ral
/
scrapy
mirror of https://github.com/scrapy/scrapy.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix exit code 5 in botocore/mitmproxy tox envs 

These envs filter tests with -m requires_botocore / -m requires_mitmproxy.
When delta selects non-matching tests based on the diff, pytest finds no
tests to run for that marker and exits with code 5 (no tests collected).

Revert these three envs back to plain pytest since they are already
highly filtered and delta provides no benefit here.
This commit is contained in:
aliowka 2026-06-17 10:36:51 +03:00
parent bfc753dbee
commit 699cdb93ed
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
tox.ini
View File

@ -322,7 +322,9 @@ deps =
{[testenv]deps}
botocore>=1.13.45
commands =
delta run -- {posargs:--cov-config=pyproject.toml --cov=scrapy --cov-report=xml --cov-report= tests --junitxml=botocore.junit.xml -o junit_family=legacy} -m requires_botocore
# Not using delta run here: tests are already marker-filtered to -m requires_botocore.
# Delta selecting non-botocore tests then filtering by marker yields exit code 5 (no tests collected).
pytest {posargs:--cov-config=pyproject.toml --cov=scrapy --cov-report=xml --cov-report= tests --junitxml=botocore.junit.xml -o junit_family=legacy} -m requires_botocore
[testenv:min-botocore]
basepython = {[min]basepython}
@ -334,7 +336,8 @@ deps =
setenv =
{[min]setenv}
commands =
delta run -- {posargs:--cov-config=pyproject.toml --cov=scrapy --cov-report=xml --cov-report= tests --junitxml=min-botocore.junit.xml -o junit_family=legacy} -m requires_botocore
# Not using delta run here: tests are already marker-filtered to -m requires_botocore.
pytest {posargs:--cov-config=pyproject.toml --cov=scrapy --cov-report=xml --cov-report= tests --junitxml=min-botocore.junit.xml -o junit_family=legacy} -m requires_botocore
# Run proxy tests that use mitmproxy in a separate env to avoid installing
@ -348,4 +351,6 @@ deps =
mitmproxy; implementation_name != "pypy"
httpx[http2,socks]
commands =
delta run -- {posargs:--cov-config=pyproject.toml --cov=scrapy --cov-report=xml --cov-report= tests --junitxml=mitmproxy.junit.xml -o junit_family=legacy} -m requires_mitmproxy
# Not using delta run here: tests are already marker-filtered to -m requires_mitmproxy.
# Delta selecting non-mitmproxy tests then filtering by marker yields exit code 5 (no tests collected).
pytest {posargs:--cov-config=pyproject.toml --cov=scrapy --cov-report=xml --cov-report= tests --junitxml=mitmproxy.junit.xml -o junit_family=legacy} -m requires_mitmproxy