From 6a50af05d74a9e22e5d1476e7312209c27be8372 Mon Sep 17 00:00:00 2001 From: Pablo Hoffman Date: Tue, 1 Sep 2009 22:49:15 -0300 Subject: [PATCH] removed useless SpiderReloader extension --- docs/topics/extensions.rst | 11 ----------- docs/topics/settings.rst | 1 - scrapy/conf/default_settings.py | 1 - scrapy/contrib/spider/reloader.py | 19 ------------------- 4 files changed, 32 deletions(-) delete mode 100644 scrapy/contrib/spider/reloader.py diff --git a/docs/topics/extensions.rst b/docs/topics/extensions.rst index 4a0016f83..95bedb67b 100644 --- a/docs/topics/extensions.rst +++ b/docs/topics/extensions.rst @@ -232,17 +232,6 @@ The telnet console must be enabled by the :setting:`TELNETCONSOLE_ENABLED` setting, and the server will listen in the port specified in :setting:`WEBCONSOLE_PORT`. -Spider reloader extension -~~~~~~~~~~~~~~~~~~~~~~~~~ - -.. module:: scrapy.contrib.spider.reloader - :synopsis: Spider reloader extension - -.. class:: scrapy.contrib.spider.reloader.SpiderReloader - -Reload spider objects once they've finished scraping, to release the resources -and references to other objects they may hold. - .. _topics-extensions-ref-memusage: Memory usage extension diff --git a/docs/topics/settings.rst b/docs/topics/settings.rst index 9f832df41..0823b63fc 100644 --- a/docs/topics/settings.rst +++ b/docs/topics/settings.rst @@ -492,7 +492,6 @@ Default:: 'scrapy.contrib.webconsole.spiderctl.Spiderctl': 0, 'scrapy.contrib.webconsole.enginestatus.EngineStatus': 0, 'scrapy.contrib.webconsole.stats.StatsDump': 0, - 'scrapy.contrib.spider.reloader.SpiderReloader': 0, 'scrapy.contrib.memusage.MemoryUsage': 0, 'scrapy.contrib.memdebug.MemoryDebugger': 0, 'scrapy.contrib.closedomain.CloseDomain': 0, diff --git a/scrapy/conf/default_settings.py b/scrapy/conf/default_settings.py index d14d4958f..04fee1738 100644 --- a/scrapy/conf/default_settings.py +++ b/scrapy/conf/default_settings.py @@ -81,7 +81,6 @@ EXTENSIONS_BASE = { 'scrapy.contrib.webconsole.spiderctl.Spiderctl': 0, 'scrapy.contrib.webconsole.enginestatus.EngineStatus': 0, 'scrapy.contrib.webconsole.stats.StatsDump': 0, - 'scrapy.contrib.spider.reloader.SpiderReloader': 0, 'scrapy.contrib.memusage.MemoryUsage': 0, 'scrapy.contrib.memdebug.MemoryDebugger': 0, 'scrapy.contrib.closedomain.CloseDomain': 0, diff --git a/scrapy/contrib/spider/reloader.py b/scrapy/contrib/spider/reloader.py deleted file mode 100644 index 6b60b7534..000000000 --- a/scrapy/contrib/spider/reloader.py +++ /dev/null @@ -1,19 +0,0 @@ -""" -Reload spider modules once they are finished scraping - -This is to release any resources held on to by scraping spiders. -""" -import sys -from scrapy.xlib.pydispatch import dispatcher -from scrapy.core import signals -from scrapy import log - -class SpiderReloader(object): - - def __init__(self): - dispatcher.connect(self.domain_closed, signal=signals.domain_closed) - - def domain_closed(self, domain, spider): - module = spider.__module__ - log.msg("reloading module %s" % module, domain=domain) - reload(sys.modules[module])