From 74413ff989036edc5e4b1dd1b68182345ddd8e69 Mon Sep 17 00:00:00 2001 From: Shane Evans Date: Wed, 16 Feb 2011 18:30:50 -0200 Subject: [PATCH] prevent incorrect assertion error possible when spiders are closing --- scrapy/core/engine.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scrapy/core/engine.py b/scrapy/core/engine.py index abd98f2d5..207517826 100644 --- a/scrapy/core/engine.py +++ b/scrapy/core/engine.py @@ -130,10 +130,10 @@ class ExecutionEngine(object): return len(self.downloader.sites) < self.downloader.concurrent_spiders def crawl(self, request, spider): - assert spider in self.open_spiders, \ - "Spider %r not opened when crawling: %s" % (spider.name, request) if spider in self.closing: # ignore requests for spiders being closed return + assert spider in self.open_spiders, \ + "Spider %r not opened when crawling: %s" % (spider.name, request) schd = mustbe_deferred(self.schedule, request, spider) # FIXME: we can't log errors because we would be preventing them from # propagating to the request errback. This should be fixed after the