From 7de9ed5bd42052f6491c939513adde6f6243ce2f Mon Sep 17 00:00:00 2001
From: PluT00 <314lut00@gmail.com>
Date: Sun, 1 May 2022 01:34:35 +0300
Subject: [PATCH 1/4] Deprecate scrapy.pipelines.images.NoimagesDrop

---
 scrapy/pipelines/images.py | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/scrapy/pipelines/images.py b/scrapy/pipelines/images.py
index 9c99dc69e..df4575a41 100644
--- a/scrapy/pipelines/images.py
+++ b/scrapy/pipelines/images.py
@@ -15,10 +15,12 @@ from scrapy.http import Request
 from scrapy.pipelines.files import FileException, FilesPipeline
 # TODO: from scrapy.pipelines.media import MediaPipeline
 from scrapy.settings import Settings
+from scrapy.utils.decorators import deprecated
 from scrapy.utils.misc import md5sum
 from scrapy.utils.python import to_bytes
 
 
+@deprecated()
 class NoimagesDrop(DropItem):
     """Product with no images exception"""
 

From 9f659bd63c04656f1c0601d6338f9050d5049fe8 Mon Sep 17 00:00:00 2001
From: PluT00 <314lut00@gmail.com>
Date: Sun, 1 May 2022 13:36:15 +0300
Subject: [PATCH 2/4] Fix deprecation of scrapy.pipelines.images.NoimagesDrop

---
 scrapy/pipelines/images.py | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/scrapy/pipelines/images.py b/scrapy/pipelines/images.py
index df4575a41..c7a04a0cf 100644
--- a/scrapy/pipelines/images.py
+++ b/scrapy/pipelines/images.py
@@ -5,25 +5,28 @@ See documentation in topics/media-pipeline.rst
 """
 import functools
 import hashlib
+import warnings
 from contextlib import suppress
 from io import BytesIO
 
 from itemadapter import ItemAdapter
 
-from scrapy.exceptions import DropItem, NotConfigured
+from scrapy.exceptions import DropItem, NotConfigured, ScrapyDeprecationWarning
 from scrapy.http import Request
 from scrapy.pipelines.files import FileException, FilesPipeline
 # TODO: from scrapy.pipelines.media import MediaPipeline
 from scrapy.settings import Settings
-from scrapy.utils.decorators import deprecated
 from scrapy.utils.misc import md5sum
 from scrapy.utils.python import to_bytes
 
 
-@deprecated()
 class NoimagesDrop(DropItem):
     """Product with no images exception"""
 
+    def __init__(self, *args, **kwargs):
+        warnings.warn("The NoimagesDrop class is deprecated", category=ScrapyDeprecationWarning, stacklevel=2)
+        super().__init__(*args, **kwargs)
+
 
 class ImageException(FileException):
     """General image error exception"""

From cc16af35af8b20e04b42ca84431820b2b092f379 Mon Sep 17 00:00:00 2001
From: PluT00 <314lut00@gmail.com>
Date: Tue, 3 May 2022 11:29:21 +0300
Subject: [PATCH 3/4] Add deprecation warning test for
 scrapy.pipelines.images.NoimagesDrop

---
 tests/test_pipeline_images.py | 20 +++++++++++++++++++-
 1 file changed, 19 insertions(+), 1 deletion(-)

diff --git a/tests/test_pipeline_images.py b/tests/test_pipeline_images.py
index c69cd0e4a..613190f9c 100644
--- a/tests/test_pipeline_images.py
+++ b/tests/test_pipeline_images.py
@@ -4,14 +4,16 @@ import random
 from shutil import rmtree
 from tempfile import mkdtemp
 from unittest import skipIf
+from warnings import catch_warnings
 
 import attr
 from itemadapter import ItemAdapter
 from twisted.trial import unittest
 
+from scrapy.exceptions import ScrapyDeprecationWarning
 from scrapy.http import Request, Response
 from scrapy.item import Field, Item
-from scrapy.pipelines.images import ImagesPipeline
+from scrapy.pipelines.images import ImagesPipeline, NoimagesDrop
 from scrapy.settings import Settings
 from scrapy.utils.python import to_bytes
 
@@ -413,6 +415,22 @@ class ImagesPipelineTestCaseCustomSettings(unittest.TestCase):
                              expected_value)
 
 
+class NoimagesDropTestCase(unittest.TestCase):
+
+    def test_deprecation_warning(self):
+        arg = str()
+        with catch_warnings(record=True) as warnings:
+            NoimagesDrop(arg)
+            self.assertEqual(len(warnings), 1)
+            self.assertEqual(warnings[0].category, ScrapyDeprecationWarning)
+        with catch_warnings(record=True) as warnings:
+            class SubclassedNoimagesDrop(NoimagesDrop):
+                pass
+            SubclassedNoimagesDrop(arg)
+            self.assertEqual(len(warnings), 1)
+            self.assertEqual(warnings[0].category, ScrapyDeprecationWarning)
+
+
 def _create_image(format, *a, **kw):
     buf = io.BytesIO()
     Image.new(*a, **kw).save(buf, format)

From ca50af645390e38299082d9ef4682c4be482ae70 Mon Sep 17 00:00:00 2001
From: Andrey Rakhmatullin <wrar@wrar.name>
Date: Thu, 27 Oct 2022 17:12:26 +0600
Subject: [PATCH 4/4] Remove an unused import.

---
 tests/test_pipeline_images.py | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tests/test_pipeline_images.py b/tests/test_pipeline_images.py
index c4ce2736f..c189d08bf 100644
--- a/tests/test_pipeline_images.py
+++ b/tests/test_pipeline_images.py
@@ -4,7 +4,6 @@ import io
 import random
 from shutil import rmtree
 from tempfile import mkdtemp
-from unittest import skipIf
 from warnings import catch_warnings
 
 import attr