From 77ce43b5c4202ebc339071aa259ed33cfa65604e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jes=C3=BAs=20Losada?= Date: Fri, 22 Jul 2016 19:47:29 +0200 Subject: [PATCH 1/2] Fix IMAGES_EXPIRES default value The default value should be 90. --- scrapy/pipelines/images.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scrapy/pipelines/images.py b/scrapy/pipelines/images.py index 964541d6a..af5825c0b 100644 --- a/scrapy/pipelines/images.py +++ b/scrapy/pipelines/images.py @@ -42,7 +42,7 @@ class ImagesPipeline(FilesPipeline): # ImagesPipeline. They may be overridden by settings. MIN_WIDTH = 0 MIN_HEIGHT = 0 - EXPIRES = 0 + EXPIRES = 90 THUMBS = {} DEFAULT_IMAGES_URLS_FIELD = 'image_urls' DEFAULT_IMAGES_RESULT_FIELD = 'images' From a486042fe586cfc6b63171135e8a872e2bb2b922 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jes=C3=BAs=20Losada?= Date: Fri, 22 Jul 2016 20:03:49 +0200 Subject: [PATCH 2/2] Fix ImagesPipeline test settings --- tests/test_pipeline_images.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/test_pipeline_images.py b/tests/test_pipeline_images.py index 6ccd9791e..8286582de 100644 --- a/tests/test_pipeline_images.py +++ b/tests/test_pipeline_images.py @@ -221,7 +221,7 @@ class ImagesPipelineTestCaseCustomSettings(unittest.TestCase): default_pipeline_settings = dict( MIN_WIDTH=0, MIN_HEIGHT=0, - EXPIRES=0, + EXPIRES=90, THUMBS={}, IMAGES_URLS_FIELD='image_urls', IMAGES_RESULT_FIELD='images'