From 7ba972d8cf833902b29082dc4802604f8d34b9c6 Mon Sep 17 00:00:00 2001 From: Pablo Hoffman Date: Thu, 4 Nov 2010 16:27:47 -0200 Subject: [PATCH] get_spider_list_from_eggfile(): fail if unable to extract spider list --- scrapyd/eggutils.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/scrapyd/eggutils.py b/scrapyd/eggutils.py index c507f0be5..d5bda5197 100644 --- a/scrapyd/eggutils.py +++ b/scrapyd/eggutils.py @@ -18,8 +18,11 @@ def get_spider_list_from_eggfile(eggfile, project): env = os.environ.copy() env['SCRAPY_PROJECT'] = project env['SCRAPY_EGGFILE'] = f.name - proc = Popen(pargs, stdout=PIPE, cwd=tmpdir, env=env) - out = proc.communicate()[0] + proc = Popen(pargs, stdout=PIPE, stderr=PIPE, cwd=tmpdir, env=env) + out, err = proc.communicate() + if proc.returncode: + msg = err.splitlines()[-1] if err else "unknown error" + raise RuntimeError(msg) return out.splitlines() finally: shutil.rmtree(tmpdir)