From 7f0e9986625fc0892dd9bb81d2979090fc11aadf Mon Sep 17 00:00:00 2001 From: Andrey Rakhmatullin Date: Sat, 11 Jul 2026 23:03:03 +0500 Subject: [PATCH] Remove IFeedStorage from the tests. --- tests/test_feedexport.py | 5 ----- tests/test_feedexport_batch.py | 6 +----- tests/test_feedexport_storages.py | 9 --------- 3 files changed, 1 insertion(+), 19 deletions(-) diff --git a/tests/test_feedexport.py b/tests/test_feedexport.py index 7d751f188..557c4bb1b 100644 --- a/tests/test_feedexport.py +++ b/tests/test_feedexport.py @@ -20,7 +20,6 @@ import lxml.etree import pytest from testfixtures import LogCapture from w3lib.url import file_uri_to_path -from zope.interface import implementer import scrapy from scrapy import Spider, signals @@ -31,7 +30,6 @@ from scrapy.extensions.feedexport import ( FeedExporter, FeedSlot, FileFeedStorage, - IFeedStorage, ) from scrapy.utils.python import to_unicode from scrapy.utils.test import get_crawler @@ -91,7 +89,6 @@ class FailingBlockingFeedStorage(DummyBlockingFeedStorage): raise OSError("Cannot store") -@implementer(IFeedStorage) class LogOnStoreFileStorage: """ This storage logs inside `store` method. @@ -1234,7 +1231,6 @@ class TestFeedExport(TestFeedExportBase): @coroutine_test async def test_storage_file_no_postprocessing(self): - @implementer(IFeedStorage) class Storage: def __init__(self, uri, *, feed_options=None): pass @@ -1256,7 +1252,6 @@ class TestFeedExport(TestFeedExportBase): @coroutine_test async def test_storage_file_postprocessing(self): - @implementer(IFeedStorage) class Storage: def __init__(self, uri, *, feed_options=None): pass diff --git a/tests/test_feedexport_batch.py b/tests/test_feedexport_batch.py index 469985288..a7547a30c 100644 --- a/tests/test_feedexport_batch.py +++ b/tests/test_feedexport_batch.py @@ -12,12 +12,11 @@ from urllib.parse import urljoin import lxml.etree import pytest from packaging.version import Version -from zope.interface.verify import verifyObject import scrapy from scrapy import Spider from scrapy.exceptions import NotConfigured -from scrapy.extensions.feedexport import FeedExporter, IFeedStorage, S3FeedStorage +from scrapy.extensions.feedexport import FeedExporter, S3FeedStorage from scrapy.settings import Settings from scrapy.utils.python import to_unicode from scrapy.utils.test import get_crawler @@ -435,9 +434,6 @@ class TestBatchDeliveries(TestFeedExportBase): }, }, } - crawler = get_crawler(settings_dict=settings) - storage = S3FeedStorage.from_crawler(crawler, uri) - verifyObject(IFeedStorage, storage) class TestSpider(scrapy.Spider): name = "testspider" diff --git a/tests/test_feedexport_storages.py b/tests/test_feedexport_storages.py index 11e79775f..cddbc5f97 100644 --- a/tests/test_feedexport_storages.py +++ b/tests/test_feedexport_storages.py @@ -12,7 +12,6 @@ from urllib.parse import quote import pytest from testfixtures import LogCapture from w3lib.url import path_to_file_uri -from zope.interface.verify import verifyObject import scrapy from scrapy.extensions.feedexport import ( @@ -20,7 +19,6 @@ from scrapy.extensions.feedexport import ( FileFeedStorage, FTPFeedStorage, GCSFeedStorage, - IFeedStorage, S3FeedStorage, StdoutFeedStorage, ) @@ -71,11 +69,6 @@ class TestFileFeedStorage: finally: os.chdir(old_cwd) - def test_interface(self, tmp_path): - path = tmp_path / "file.txt" - st = FileFeedStorage(str(path)) - verifyObject(IFeedStorage, st) - @staticmethod def _store(path: Path, feed_options: dict[str, Any] | None = None) -> None: storage = FileFeedStorage(str(path), feed_options=feed_options) @@ -131,7 +124,6 @@ class TestFTPFeedStorage: uri, feed_options=feed_options, ) - verifyObject(IFeedStorage, storage) spider = self.get_test_spider() file = storage.open(spider) file.write(content) @@ -275,7 +267,6 @@ class TestS3FeedStorage: bucket = "mybucket" key = "export.csv" storage = S3FeedStorage.from_crawler(crawler, f"s3://{bucket}/{key}") - verifyObject(IFeedStorage, storage) file = mock.MagicMock()