Move install_asyncio_reactor() from commands to CrawlerProcess.

This commit is contained in:
Andrey Rakhmatullin 2019-12-13 18:11:49 +05:00
parent 69cd2e247e
commit 855bbebc8b
3 changed files with 3 additions and 6 deletions

View File

@ -1,6 +1,5 @@
import os
from scrapy.commands import ScrapyCommand
from scrapy.utils.asyncio import install_asyncio_reactor
from scrapy.utils.conf import arglist_to_dict
from scrapy.utils.python import without_none_values
from scrapy.exceptions import UsageError
@ -27,8 +26,6 @@ class Command(ScrapyCommand):
def process_options(self, args, opts):
ScrapyCommand.process_options(self, args, opts)
if self.settings.getbool('ASYNCIO_ENABLED'):
install_asyncio_reactor()
try:
opts.spargs = arglist_to_dict(opts.spargs)
except ValueError:

View File

@ -2,7 +2,6 @@ import sys
import os
from importlib import import_module
from scrapy.utils.asyncio import install_asyncio_reactor
from scrapy.utils.spider import iter_spider_classes
from scrapy.commands import ScrapyCommand
from scrapy.exceptions import UsageError
@ -51,8 +50,6 @@ class Command(ScrapyCommand):
def process_options(self, args, opts):
ScrapyCommand.process_options(self, args, opts)
if self.settings.getbool('ASYNCIO_ENABLED'):
install_asyncio_reactor()
try:
opts.spargs = arglist_to_dict(opts.spargs)
except ValueError:

View File

@ -14,6 +14,7 @@ from scrapy.extension import ExtensionManager
from scrapy.settings import overridden_settings, Settings
from scrapy.signalmanager import SignalManager
from scrapy.exceptions import ScrapyDeprecationWarning
from scrapy.utils.asyncio import install_asyncio_reactor
from scrapy.utils.ossignal import install_shutdown_handlers, signal_names
from scrapy.utils.misc import load_object
from scrapy.utils.log import (
@ -256,6 +257,8 @@ class CrawlerProcess(CrawlerRunner):
def __init__(self, settings=None, install_root_handler=True):
super(CrawlerProcess, self).__init__(settings)
if self.settings.getbool('ASYNCIO_ENABLED'):
install_asyncio_reactor()
install_shutdown_handlers(self._signal_shutdown)
configure_logging(self.settings, install_root_handler)
log_scrapy_info(self.settings)