From 8f01ef73d2d9d528fe60f8be39362ea47e2417ca Mon Sep 17 00:00:00 2001
From: C1-BA-B1-F3 <C1-BA-B1-F3@users.noreply.github.com>
Date: Fri, 26 Jun 2026 03:42:48 +0800
Subject: [PATCH] fix: FTPDownloadHandler close connections after download

FTPDownloadHandler.download_request() created an FTPClient but never
closed the control connection after the transfer completed or failed.

Changes:
- Add finally block to call client.transport.loseConnection() so the
  TCP connection is always torn down
- Move protocol.close() into the finally block so ReceivedDataProtocol
  resources (file handles, memory buffers) are released in all paths
- Add tests verifying loseConnection() and protocol.close() are called
  on both success and error paths

Fixes scrapy/scrapy#7602
---
 scrapy/core/downloader/handlers/ftp.py       |  5 +-
 tests/test_downloader_handler_twisted_ftp.py | 80 ++++++++++++++++++++
 2 files changed, 84 insertions(+), 1 deletion(-)

diff --git a/scrapy/core/downloader/handlers/ftp.py b/scrapy/core/downloader/handlers/ftp.py
index 6258067c1..9064aa53a 100644
--- a/scrapy/core/downloader/handlers/ftp.py
+++ b/scrapy/core/downloader/handlers/ftp.py
@@ -119,7 +119,10 @@ class FTPDownloadHandler(BaseDownloadHandler):
                 httpcode = self.CODE_MAPPING.get(ftpcode, self.CODE_MAPPING["default"])
                 return Response(url=request.url, status=httpcode, body=message.encode())
             raise
-        protocol.close()
+        finally:
+            protocol.close()
+            assert client.transport
+            client.transport.loseConnection()
         headers = {"local filename": protocol.filename or b"", "size": protocol.size}
         body = protocol.filename or protocol.body.read()
         respcls = responsetypes.from_args(url=request.url, body=body)
diff --git a/tests/test_downloader_handler_twisted_ftp.py b/tests/test_downloader_handler_twisted_ftp.py
index 489b70e74..dee0be037 100644
--- a/tests/test_downloader_handler_twisted_ftp.py
+++ b/tests/test_downloader_handler_twisted_ftp.py
@@ -205,3 +205,83 @@ def test_not_configured_without_reactor() -> None:
     crawler = Crawler(Spider, {"TWISTED_REACTOR_ENABLED": False})
     with pytest.raises(NotConfigured):
         FTPDownloadHandler.from_crawler(crawler)
+
+
+class TestFTPCleanup(TestFTPBase):
+    def _create_files(self, root: Path) -> None:
+        userdir = root / self.username
+        userdir.mkdir()
+        for filename, content in self.test_files:
+            (userdir / filename).write_bytes(content)
+
+    def _get_factory(self, root):
+        from twisted.protocols.ftp import FTPFactory, FTPRealm
+
+        realm = FTPRealm(anonymousRoot=str(root), userHome=str(root))
+        p = portal.Portal(realm)
+        users_checker = checkers.InMemoryUsernamePasswordDatabaseDontUse()
+        users_checker.addUser(self.username, self.password)
+        p.registerChecker(users_checker, credentials.IUsernamePassword)
+        return FTPFactory(portal=p)
+
+    @deferred_f_from_coro_f
+    async def test_lose_connection_called_on_success(
+        self, server_url: str
+    ) -> None:
+        from unittest.mock import patch
+
+        from scrapy.core.downloader.handlers.ftp import ReceivedDataProtocol
+
+        lose_calls: list[bool] = []
+        close_calls: list[bool] = []
+        original_close = ReceivedDataProtocol.close
+
+        def tracking_close(self):
+            close_calls.append(True)
+            original_close(self)
+
+        with patch.object(ReceivedDataProtocol, "close", tracking_close), patch(
+            "twisted.internet.tcp.Client.loseConnection"
+        ) as mock_lose:
+            mock_lose.side_effect = lambda: lose_calls.append(True)
+            crawler = get_crawler()
+            dh = build_from_crawler(FTPDownloadHandler, crawler)
+            request = Request(
+                url=server_url + "file.txt",
+                meta={"ftp_user": "scrapy", "ftp_password": "passwd"},
+            )
+            r = await dh.download_request(request)
+            assert r.status == 200
+            assert close_calls, "protocol.close() was not called"
+            assert lose_calls, "transport.loseConnection() was not called"
+
+    @deferred_f_from_coro_f
+    async def test_lose_connection_called_on_error(
+        self, server_url: str
+    ) -> None:
+        from unittest.mock import patch
+
+        from scrapy.core.downloader.handlers.ftp import ReceivedDataProtocol
+
+        lose_calls: list[bool] = []
+        close_calls: list[bool] = []
+        original_close = ReceivedDataProtocol.close
+
+        def tracking_close(self):
+            close_calls.append(True)
+            original_close(self)
+
+        with patch.object(ReceivedDataProtocol, "close", tracking_close), patch(
+            "twisted.internet.tcp.Client.loseConnection"
+        ) as mock_lose:
+            mock_lose.side_effect = lambda: lose_calls.append(True)
+            crawler = get_crawler()
+            dh = build_from_crawler(FTPDownloadHandler, crawler)
+            request = Request(
+                url=server_url + "nonexistent.txt",
+                meta={"ftp_user": "scrapy", "ftp_password": "passwd"},
+            )
+            r = await dh.download_request(request)
+            assert r.status == 404
+            assert close_calls, "protocol.close() was not called on error"
+            assert lose_calls, "transport.loseConnection() was not called on error"