From 8f53a723064c44c1f75ab0b7be41bd1c7edbd001 Mon Sep 17 00:00:00 2001 From: Ping Yin Date: Sat, 24 Apr 2010 21:21:12 +0800 Subject: [PATCH] ItemLoader: add test for adding a dict value After arg_to_iter is changed to return [arg] if arg is a dict, the added test will pass. Signed-off-by: Ping Yin --- scrapy/tests/test_contrib_loader.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/scrapy/tests/test_contrib_loader.py b/scrapy/tests/test_contrib_loader.py index 612837ee8..0c0988756 100644 --- a/scrapy/tests/test_contrib_loader.py +++ b/scrapy/tests/test_contrib_loader.py @@ -61,6 +61,10 @@ class ItemLoaderTest(unittest.TestCase): self.assertEqual(il.get_collected_values('name'), [u'Marta', u'Pepe']) self.assertEqual(il.get_output_value('name'), [u'Marta', u'Pepe']) + # test add object value + il.add_value('summary', {'key': 1}) + self.assertEqual(il.get_collected_values('summary'), [{'key': 1}]) + il.add_value(None, u'Jim', lambda x: {'name': x}) self.assertEqual(il.get_collected_values('name'), [u'Marta', u'Pepe', u'Jim'])