RomanNum3ral
/
scrapy
mirror of https://github.com/scrapy/scrapy.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #6290 from Gallaecio/fix-skips 

Fix WindowsRunSpiderCommandTest skip outside Windows for older Twisted
This commit is contained in:
Andrey Rakhmatullin 2024-03-12 14:17:10 +05:00 committed by GitHub
parent d7581c6b41 e72de11f55
commit 95a70d3fa0
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tests/test_commands.py
View File

@ -987,10 +987,14 @@ class MySpider(scrapy.Spider):
self.assertIn("The value of FOO is 42", log)
@skipIf(platform.system() != "Windows", "Windows required for .pyw files")
class WindowsRunSpiderCommandTest(RunSpiderCommandTest):
spider_filename = "myspider.pyw"
def setUp(self):
if platform.system() != "Windows":
raise unittest.SkipTest("Windows required for .pyw files")
return super().setUp()
def test_start_requests_errors(self):
log = self.get_log(self.badspider, name="badspider.pyw")
self.assertIn("start_requests", log)