RomanNum3ral
/
scrapy
mirror of https://github.com/scrapy/scrapy.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Link.__eq__: return NotImplemented instead of raising NotImplementedError (#7611)

This commit is contained in:
Adrian 2026-06-12 14:56:15 +02:00 committed by GitHub
parent b08ed1cf05
commit 983e6c1182
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
scrapy/link.py
View File

@ -39,7 +39,7 @@ class Link:
def __eq__(self, other: object) -> bool: def __eq__(self, other: object) -> bool:
if not isinstance(other, Link): if not isinstance(other, Link):
raise NotImplementedError return NotImplemented
return ( return (
self.url == other.url self.url == other.url
and self.text == other.text and self.text == other.text

4
tests/test_link.py
View File

@ -55,3 +55,7 @@ class TestLink:
def test_bytes_url(self): def test_bytes_url(self):
with pytest.raises(TypeError): with pytest.raises(TypeError):
Link(b"http://www.example.com/\xc2\xa3") Link(b"http://www.example.com/\xc2\xa3")
def test_eq_non_link(self):
url = "http://example.com"
assert Link(url) != url