From 1ed5643eb2237f588044a6595d5e56d8e54039c2 Mon Sep 17 00:00:00 2001 From: nramirezuy Date: Tue, 28 May 2013 12:42:50 -0300 Subject: [PATCH] added test for bench command --- scrapy/contrib/closespider.py | 2 +- scrapy/tests/test_commands.py | 9 +++++++++ 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/scrapy/contrib/closespider.py b/scrapy/contrib/closespider.py index d9b01e689..645393d6b 100644 --- a/scrapy/contrib/closespider.py +++ b/scrapy/contrib/closespider.py @@ -15,7 +15,7 @@ class CloseSpider(object): def __init__(self, crawler): self.crawler = crawler - self.timeout = crawler.settings.getint('CLOSESPIDER_TIMEOUT') + self.timeout = crawler.settings.getfloat('CLOSESPIDER_TIMEOUT') self.itemcount = crawler.settings.getint('CLOSESPIDER_ITEMCOUNT') self.pagecount = crawler.settings.getint('CLOSESPIDER_PAGECOUNT') self.errorcount = crawler.settings.getint('CLOSESPIDER_ERRORCOUNT') diff --git a/scrapy/tests/test_commands.py b/scrapy/tests/test_commands.py index 0389d1765..973b60a05 100644 --- a/scrapy/tests/test_commands.py +++ b/scrapy/tests/test_commands.py @@ -226,3 +226,12 @@ ITEM_PIPELINES = ['{0}.pipelines.MyPipeline'] '-c', 'parse', 'http://scrapinghub.com') log = p.stderr.read() self.assert_("[scrapy] INFO: It Works!" in log, log) + + +class BenchCommandTest(CommandTest): + + def test_run(self): + p = self.proc('bench', '-s', 'LOGSTATS_INTERVAL=0.001', + '-s', 'CLOSESPIDER_TIMEOUT=0.01') + log = p.stderr.read() + self.assert_('INFO: Crawled' in log, log)