RomanNum3ral
/
scrapy
mirror of https://github.com/scrapy/scrapy.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: drop misleading threaded resolver test 

it was writing directly to dnscache, not actually going through
CachingThreadedResolver at all. the threaded resolver already has
its own if dnscache.limit: guard so the bug doesnt affect it anyway.

keeping only the hostname resolver test which covers the actual
bug path through _CachingResolutionReceiver
This commit is contained in:
tanishqtayade 2026-06-26 12:09:11 +05:30
parent b136f59daf
commit 9944e28a06
1 changed files with 0 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
tests/test_resolver.py
View File

@ -75,12 +75,3 @@ def test_caching_hostname_resolver_dnscache_disabled_rejects_storage():
# dnscache should remain empty despite address being resolved
assert "example.com" not in dnscache
assert len(dnscache) == 0
def test_caching_threaded_resolver_dnscache_disabled_rejects_storage():
# Regression test: when DNSCACHE_ENABLED=False, resolved DNS results
# should not be stored in dnscache even after successful resolution.
dnscache.limit = 0
dnscache["example.com"] = "1.2.3.4"
assert "example.com" not in dnscache
assert len(dnscache) == 0