RomanNum3ral
/
scrapy
mirror of https://github.com/scrapy/scrapy.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Deprecate scrapy.utils.python.MutableChain.next

This commit is contained in:
Adrián Chaves 2019-11-18 10:58:47 +01:00
parent 1a4a77d49f
commit 99d8b05a0b
2 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
scrapy/utils/python.py
View File

@ -392,3 +392,7 @@ class MutableChain(object):
def __next__(self):
return next(self.data)
@deprecated("scrapy.utils.python.MutableChain.__next__")
def next(self):
return self.__next__()

8
tests/test_utils_python.py
View File

@ -5,6 +5,7 @@ import unittest
from itertools import count
import platform
import six
from warnings import catch_warnings
from scrapy.utils.python import (
memoizemethod_noargs, binary_is_text, equal_attributes,
@ -22,7 +23,12 @@ class MutableChainTest(unittest.TestCase):
m.extend([9, 10], (11, 12))
self.assertEqual(next(m), 0)
self.assertEqual(m.__next__(), 1)
self.assertEqual(list(m), list(range(2, 13)))
with catch_warnings(record=True) as warnings:
self.assertEqual(m.next(), 2)
self.assertEqual(len(warnings), 1)
self.assertIn('scrapy.utils.python.MutableChain.__next__',
str(warnings[0].message))
self.assertEqual(list(m), list(range(3, 13)))
class ToUnicodeTest(unittest.TestCase):