Explicit argument names

This commit is contained in:
Eugenio Lacuesta 2019-12-23 20:26:58 -03:00
parent 2fb160e3ba
commit 9a75b46fb8
No known key found for this signature in database
GPG Key ID: DA3EF2D0913E9810
3 changed files with 8 additions and 4 deletions

View File

@ -29,7 +29,7 @@ class HTTP10DownloadHandler:
host, port = to_unicode(factory.host), factory.port
if factory.scheme == b'https':
client_context_factory = create_instance(
self.ClientContextFactory,
objcls=self.ClientContextFactory,
settings=self._settings,
crawler=self._crawler,
)

View File

@ -41,7 +41,7 @@ class HTTP11DownloadHandler:
# try method-aware context factory
try:
self._contextFactory = create_instance(
self._contextFactoryClass,
objcls=self._contextFactoryClass,
settings=settings,
crawler=crawler,
method=self._sslMethod,
@ -49,7 +49,7 @@ class HTTP11DownloadHandler:
except TypeError:
# use context factory defaults
self._contextFactory = create_instance(
self._contextFactoryClass,
objcls=self._contextFactoryClass,
settings=settings,
crawler=crawler,
)

View File

@ -68,7 +68,11 @@ class S3DownloadHandler:
except Exception as ex:
raise NotConfigured(str(ex))
_http_handler = create_instance(httpdownloadhandler, settings, crawler)
_http_handler = create_instance(
objcls=httpdownloadhandler,
settings=settings,
crawler=crawler,
)
self._download_http = _http_handler.download_request
@classmethod