From 9aa9dd8d45a2ce0c8e6ae0732e610f020735df7e Mon Sep 17 00:00:00 2001 From: Mikhail Korobov Date: Tue, 12 Dec 2017 19:17:00 +0500 Subject: [PATCH] DOC mention an easier way to track pull requests locally. Thanks @eliasdorneles! --- docs/contributing.rst | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/docs/contributing.rst b/docs/contributing.rst index eb736bf30..9a02634cb 100644 --- a/docs/contributing.rst +++ b/docs/contributing.rst @@ -127,9 +127,16 @@ original pull request author haven't had time to address them. In this case consider picking up this pull request: open a new pull request with all commits from the original pull request, as well as additional changes to address the raised issues. Doing so helps a lot; it is -not considered rude as soon as original the author is acknowledged by keeping +not considered rude as soon as the original author is acknowledged by keeping his/her commits. +You can pull an existing pull request to a local branch +by running ``git fetch upstream pull/$PR_NUMBER/head:$BRANCH_NAME_TO_CREATE`` +(replace 'upstream' with a remote name for scrapy repository, +``$PR_NUMBER`` with an ID of the pull request, and ``$BRANCH_NAME_TO_CREATE`` +with a name of the branch you want to create locally). +See also: https://help.github.com/articles/checking-out-pull-requests-locally/#modifying-an-inactive-pull-request-locally. + When writing GitHub pull requests, try to keep titles short but descriptive. E.g. For bug #411: "Scrapy hangs if an exception raises in start_requests" prefer "Fix hanging when exception occurs in start_requests (#411)"